Date: Sun, 9 Nov 2008 08:48:17 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Matteo Riondato <matteo@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184780 - head/usr.sbin/cron/crontab Message-ID: <20081109084817.GA23323@FreeBSD.org> In-Reply-To: <200811090734.mA97YBld033553@svn.freebsd.org> References: <200811090734.mA97YBld033553@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Nov 09, 2008 at 07:34:11AM +0000, Matteo Riondato wrote:
>
> +void
> +static remove_tmp(int sig)
> +{
> + if (tmp_path) {
> + unlink(tmp_path);
> + }
> + exit(ERROR_EXIT);
> +}
This looks weird: `static' should be on same line as `void' as `static
void' (so ^remove_tmp would match). It will also always exit with
ERROR_EXIT, which does not look right, does it?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081109084817.GA23323>