Date: Sat, 17 Dec 2016 15:49:32 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: David Chisnall <theraven@FreeBSD.org> Cc: Baptiste Daroussin <bapt@FreeBSD.org>, "Conrad E. Meyer" <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310138 - head/lib/libc/stdio Message-ID: <0BDD9ECA-AF91-4CA7-AA5D-DC7AD36AE531@FreeBSD.org> In-Reply-To: <00BFA847-B26A-453A-87DB-D5A55C1FAA38@FreeBSD.org> References: <201612160144.uBG1ipjW016736@repo.freebsd.org> <20161216193128.wgskqt4vc44vdd7o@ivaldir.etoilebsd.net> <00BFA847-B26A-453A-87DB-D5A55C1FAA38@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 17 Dec 2016, at 12:46, David Chisnall <theraven@FreeBSD.org> wrote: > > On 16 Dec 2016, at 19:31, Baptiste Daroussin <bapt@FreeBSD.org> wrote: >> >> Other than that, it makes more difficult to use vanilla gcc with out userland. >> and it is adding more complexity to be able to build freebsd from a non freebsd >> system which some people are working on. > > Why? You’ll get some spurious warnings about printf, but that’s all. Unfortunately, we compile large parts of the tree with -Werror. Thus, "spurious warnings" will break the build, leaving the user two options: disabling -Wformat warnings, or disabling -Werror altogether, neither of which are very recommendable. As far as I know, there is no -Wno-error-on-undefined-printf-specifiers. It would also be hard to implement, since after any undefined specifiers have been encountered, you cannot reason about the following ones anymore either. IMHO, if people want to use non-standard specifiers, let them define their own almost_printf_but_not_quite() functions, and forgo any format checking. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhVUIgACgkQsF6jCi4glqM6fACfawgq5SWhp1hoeRBAVu7hm2Jg 630AoNMdHKE8hODUtV3luLceSLLoruvB =kEd7 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0BDD9ECA-AF91-4CA7-AA5D-DC7AD36AE531>