Date: Sat, 10 Feb 2018 08:33:26 -0800 (PST) From: "Rodney W. Grimes" <freebsd-rwg@pdx.rh.CN85.dnsmgr.net> To: Ryan Stone <rysto32@gmail.com> Cc: freebsd-net <freebsd-net@freebsd.org> Subject: Re: Review: Fix regression that did not allow "route change" that didn't re-specify the gateway Message-ID: <201802101633.w1AGXRSY035991@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CAFMmRNxjvDRm%2BPXaFK8wyahYHaRTERR%2BkBH1=y6NbGz%2B5UGdig@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> A change a while back (r264986) broke the ability to change a route's
> parameters if the gateway wasn't explicitly specified again. For
Was the a feature by accident or design? As the man page does not
say that "gateway" is optional on a change command, it shows it
as a required parameter.
> example, you used to be able to run "route change 10.0.0.0/8 -mtu
> 9000" to change the MTU without having to provide the gateway IP to
> the command. I have a review open to restore the existing behaviour.
^^^^^^^^
prior?
> In cases where the gateway is not specified, the gateway on the route
> remains unchanged.
>
> Anyone interested in reviewing this change should add themselves as a
> reviewer to https://reviews.freebsd.org/D14291.
I requested a man page update in the review,
but did not mark it as blocking.
> Thanks,
> Ryan
--
Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201802101633.w1AGXRSY035991>