Date: Sun, 03 May 2015 21:52:08 -0700 From: Peter Wemm <peter@wemm.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281643 - head/sys/net Message-ID: <1771261.fW4ZlvR2Pp@overcee.wemm.org> In-Reply-To: <1897115.Jgl4mMPfrQ@overcee.wemm.org> References: <201504170639.t3H6dGd7075429@svn.freebsd.org> <1897115.Jgl4mMPfrQ@overcee.wemm.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sunday, May 03, 2015 09:31:01 PM Peter Wemm wrote: > On Friday, April 17, 2015 06:39:16 AM Gleb Smirnoff wrote: > > Author: glebius > > Date: Fri Apr 17 06:39:15 2015 > > New Revision: 281643 > > URL: https://svnweb.freebsd.org/changeset/base/281643 > > > > Log: > > Bring in if_types.h from projects/ifnet, where types are > > defined in enum. > > > > Modified: > > head/sys/net/if_types.h > > I'm sorry, but this breaks the freebsd.org cluster. > > 281642 works > 281643 fails > head with 281643 reverted works > > IPv6 doesn't work on systems with pf, carp and multiple interfaces. I have > nothing more specific than that. The kernel is smaller with the enums: text data bss dec hex 11438123 730686 2998048 15166857 0xe76d89 11437787 730686 2998048 15166521 0xe76c39 The first is with the #defines, the second is enums. The enums caused 336 bytes less code to be generated, so presumably the enums enabled some "optimization" that wasn't expected. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJVRvr4AAoJEDXWlwnsgJ4E7/kIALIQZG7zBSG4yRgZffm1QeI3 ElTzB7NbbKXscaSLOjLGL9vOC0oZuMXV3YT8Ub3q5ZlH1l9Ds2XtWtCO6o/AZZRy NdxTghzGcgDHV/oPzOdgAT1FgOjBXfECbO+Us72mujijEg0fGyq20dleVauZqs/r AOZIPLlF9So9TQHm9W2Ja1JlRwO+RNTcG4lat20LRSRVuI/i1Z1XzSeGf2JR1qnA 7hmfq+l5X9j71yP8JYgZAKux1bkRg/g8ugRNejxV6wd5sVhrIqUVLNK/hlJQOjVc bofkwNzE5pNc0nRrnO3tAgtjdOvmE4CAQgfsxxvptm2eL1pQWII3JBFkOfB/G7k= =0Fck -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1771261.fW4ZlvR2Pp>