Date: Sat, 24 Mar 2007 11:30:44 +0100 From: Andre Oppermann <andre@freebsd.org> To: Harti Brandt <harti@freebsd.org> Cc: freebsd-net@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/110720: [net] [patch] support for interface descriptions Message-ID: <4604FDD4.2080805@freebsd.org> In-Reply-To: <20070324102948.Q58113@knop-beagle.kn.op.dlr.de> References: <200703231844.l2NIiCsa089542@freefall.freebsd.org> <20070324102948.Q58113@knop-beagle.kn.op.dlr.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Harti Brandt wrote: > Nice feature, although it would be nice to align the maximum length with > IF-MIB::ifDescr (255 byte + \0). Also I suppose that the field more > naturally fits into struct if_data (see net/if.h) given the comment for > that struct: > > /* > * Structure describing information about an interface > * which may be of interest to management entities. > */ The string array should most likely not be part of struct ifnet as that would bloat it quite a bit. If it is in there it should be at the end of the struct to avoid cache line busting effects. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4604FDD4.2080805>