Date: Sun, 19 Apr 2020 13:57:23 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Cy Schubert <cy@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r360102 - in head: libexec/rc/rc.d share/mk tools/build/mk Message-ID: <EE886220-DAE1-4A55-ACC2-848F15DC3446@gmail.com> In-Reply-To: <202004191701.03JH1LFA002938@repo.freebsd.org> References: <202004191701.03JH1LFA002938@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Apr 19, 2020, at 10:01 AM, Cy Schubert <cy@FreeBSD.org> wrote: >=20 > Author: cy > Date: Sun Apr 19 17:01:21 2020 > New Revision: 360102 > URL: https://svnweb.freebsd.org/changeset/base/360102 >=20 > Log: > Conditionally install Kerberos rc files based on MK_KERBEROS_SCRIPTS > instead of MK_KERBEROS. The reason for this change is some users > prefer to build FreeBSD WITHOUT_KERBEROS, wanting to retain the > Kerberos rc scripts to start/stop MIT Kerberos or Heimdal from ports. >=20 > PR: 197337 > Reported by: Adam McDougall <ebay at looksharp.net> > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D24252 Hi Cy, Having excised code like this in the past, I don=E2=80=99t think = this is the right approach: a separate slave port should be added that = handles the rc.d script installation, etc, or the scripts should be = added to the manifest for the ports. Thanks, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EE886220-DAE1-4A55-ACC2-848F15DC3446>