Date: Wed, 30 Dec 2015 18:18:31 +0100 From: Oliver Pinter <oliver.pinter@hardenedbsd.org> To: Allan Jude <allanjude@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292782 - in head: lib/libcrypt lib/libmd sbin/gbde sbin/geom/class/eli sbin/md5 sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/conf sys/crypto/sha2 sys/dev/random sys/geom/bde sys/... Message-ID: <CAPQ4ffvYv=mu5ZVtw1mEQdoqgKmg7bM=ai4pnqkr%2BabZzKKAEw@mail.gmail.com> In-Reply-To: <201512271733.tBRHXxgN031823@repo.freebsd.org> References: <201512271733.tBRHXxgN031823@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/27/15, Allan Jude <allanjude@freebsd.org> wrote: > Author: allanjude > Date: Sun Dec 27 17:33:59 2015 > New Revision: 292782 > URL: https://svnweb.freebsd.org/changeset/base/292782 > > Log: > Replace sys/crypto/sha2/sha2.c with lib/libmd/sha512c.c > > cperciva's libmd implementation is 5-30% faster > > The same was done for SHA256 previously in r263218 > > cperciva's implementation was lacking SHA-384 which I implemented, > validated against OpenSSL and the NIST documentation > > Extend sbin/md5 to create sha384(1) > > Chase dependancies on sys/crypto/sha2/sha2.{c,h} and replace them with > sha512{c.c,.h} > > Reviewed by: cperciva, des, delphij > Approved by: secteam, bapt (mentor) > MFC after: 2 weeks > Sponsored by: ScaleEngine Inc. > Differential Revision: https://reviews.freebsd.org/D3929 > > Added: > head/sys/crypto/sha2/sha384.h (contents, props changed) > head/sys/crypto/sha2/sha512.h > - copied, changed from r292757, head/lib/libmd/sha512.h > head/sys/crypto/sha2/sha512c.c > - copied, changed from r289398, head/lib/libmd/sha512c.c > Deleted: > head/lib/libmd/sha512.h > head/lib/libmd/sha512c.c > head/sys/crypto/sha2/sha2.c > head/sys/crypto/sha2/sha2.h > Modified: > head/lib/libcrypt/Makefile > head/lib/libmd/Makefile > head/lib/libmd/sha512.3 > head/lib/libmd/shadriver.c > head/sbin/gbde/Makefile > head/sbin/gbde/gbde.c > head/sbin/geom/class/eli/Makefile > head/sbin/md5/Makefile > head/sbin/md5/md5.1 > head/sbin/md5/md5.c > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sha256.c > head/sys/conf/files > head/sys/crypto/sha2/sha256.h > head/sys/dev/random/build.sh > head/sys/dev/random/fortuna.c > head/sys/dev/random/hash.c > head/sys/dev/random/other_algorithm.c > head/sys/dev/random/randomdev.c > head/sys/dev/random/unit_test.c > head/sys/dev/random/yarrow.c > head/sys/geom/bde/g_bde.c > head/sys/geom/bde/g_bde_crypt.c > head/sys/geom/bde/g_bde_lock.c > head/sys/geom/bde/g_bde_work.c > head/sys/geom/eli/g_eli.h > head/sys/modules/crypto/Makefile > head/sys/modules/geom/geom_bde/Makefile > head/sys/modules/zfs/Makefile > head/sys/netinet/sctp_os_bsd.h > head/sys/opencrypto/xform.h > > Modified: head/lib/libcrypt/Makefile > Hi Allan! Could you please bump __FreeBSD_version after this change? This breaks the building of some external module, whose use the crypto/sha2/sha2.h file.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffvYv=mu5ZVtw1mEQdoqgKmg7bM=ai4pnqkr%2BabZzKKAEw>