Date: Tue, 10 Oct 2023 21:34:26 -0400 From: Adam Weinberger <adamw@adamw.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 0e73ed9372f0 - main - config: switch from dialog4ports to portconfig Message-ID: <CAP7rwcgj%2B6FgurdRpruoRsqCExq8rOqPOFaUbsJN1KSydR7t9Q@mail.gmail.com> In-Reply-To: <202310101158.39ABwYv1037813@gitrepo.freebsd.org> References: <202310101158.39ABwYv1037813@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000d799c2060766d355 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Baptiste, The DIALOG4PORTS option from poudriere probably needs to be switched to a PORTCONFIG option. # Adam On Tue, Oct 10, 2023 at 7:58=E2=80=AFAM Baptiste Daroussin <bapt@freebsd.or= g> wrote: > The branch main has been updated by bapt: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D0e73ed9372f074ba59d40b66b95c8= 78a7f36702e > > commit 0e73ed9372f074ba59d40b66b95c878a7f36702e > Author: Baptiste Daroussin <bapt@FreeBSD.org> > AuthorDate: 2023-10-10 11:53:44 +0000 > Commit: Baptiste Daroussin <bapt@FreeBSD.org> > CommitDate: 2023-10-10 11:58:31 +0000 > > config: switch from dialog4ports to portconfig > > dialog4ports is using libdialog which is being decommissioned from > base replaced by bsddialog. We cannot switch to depending on > devel/cdialog because it build depends on too many things, on the oth= er > hand the author of bsddialog made portconfig as a drop-in replacement > for dialog4ports, it only build depends on devel/bsddialog (we use > the version in port to be sure to have the right version on all > supported versions of the ports tree) > > Reported by: Herbert J. Skuhra" <herbert@gojira.at> > --- > Mk/Scripts/dialog4ports.sh | 4 ++-- > Mk/bsd.commands.mk | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Mk/Scripts/dialog4ports.sh b/Mk/Scripts/dialog4ports.sh > index e229d7d4bdc1..de62a91b583f 100644 > --- a/Mk/Scripts/dialog4ports.sh > +++ b/Mk/Scripts/dialog4ports.sh > @@ -10,8 +10,8 @@ if [ -z "${DIALOG4PORTS}" -o -z "${PORTSDIR}" -o -z > "${MAKE}" ]; then > exit 1 > fi > > -: ${DIALOGPORT:=3Dports-mgmt/dialog4ports} > -: ${DIALOGNAME:=3Ddialog4ports} > +: ${DIALOGPORT:=3Dports-mgmt/portconfig} > +: ${DIALOGNAME:=3Dportconfig} > > OPTIONSFILE=3D"$1" > > diff --git a/Mk/bsd.commands.mk b/Mk/bsd.commands.mk > index 7addad889763..636f2f2f481e 100644 > --- a/Mk/bsd.commands.mk > +++ b/Mk/bsd.commands.mk > @@ -33,7 +33,7 @@ DIALOG?=3D /usr/bin/dialog > .else > DIALOG?=3D /usr/bin/bsddialog > .endif > -DIALOG4PORTS?=3D ${LOCALBASE}/bin/dialog4ports > +DIALOG4PORTS?=3D ${LOCALBASE}/bin/portconfig > DIFF?=3D /usr/bin/diff > DIRNAME?=3D /usr/bin/dirname > EGREP?=3D /usr/bin/egrep > --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --000000000000d799c2060766d355 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div class=3D"gmail_default" style=3D"font-family:arial,sa= ns-serif">Hi Baptiste,</div><div class=3D"gmail_default" style=3D"font-fami= ly:arial,sans-serif"><br></div><div class=3D"gmail_default" style=3D"font-f= amily:arial,sans-serif">The DIALOG4PORTS option from poudriere probably nee= ds to be switched to a PORTCONFIG option.</div><div class=3D"gmail_default"= style=3D"font-family:arial,sans-serif"><br></div><div class=3D"gmail_defau= lt" style=3D"font-family:arial,sans-serif"># Adam</div><div class=3D"gmail_= default" style=3D"font-family:arial,sans-serif"><br></div><div class=3D"gma= il_default" style=3D"font-family:arial,sans-serif"><br></div></div><br><div= class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Oct 10= , 2023 at 7:58=E2=80=AFAM Baptiste Daroussin <<a href=3D"mailto:bapt@fre= ebsd.org">bapt@freebsd.org</a>> wrote:<br></div><blockquote class=3D"gma= il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2= 04,204);padding-left:1ex">The branch main has been updated by bapt:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D0e73ed9372f074b= a59d40b66b95c878a7f36702e" rel=3D"noreferrer" target=3D"_blank">https://cgi= t.FreeBSD.org/ports/commit/?id=3D0e73ed9372f074ba59d40b66b95c878a7f36702e</= a><br> <br> commit 0e73ed9372f074ba59d40b66b95c878a7f36702e<br> Author:=C2=A0 =C2=A0 =C2=A0Baptiste Daroussin <bapt@FreeBSD.org><br> AuthorDate: 2023-10-10 11:53:44 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Baptiste Daroussin <bapt@FreeBSD.org><br> CommitDate: 2023-10-10 11:58:31 +0000<br> <br> =C2=A0 =C2=A0 config: switch from dialog4ports to portconfig<br> <br> =C2=A0 =C2=A0 dialog4ports is using libdialog which is being decommissioned= from<br> =C2=A0 =C2=A0 base replaced by bsddialog. We cannot switch to depending on<= br> =C2=A0 =C2=A0 devel/cdialog because it build depends on too many things, on= the other<br> =C2=A0 =C2=A0 hand the author of bsddialog made portconfig as a drop-in rep= lacement<br> =C2=A0 =C2=A0 for dialog4ports, it only build depends on devel/bsddialog (w= e use<br> =C2=A0 =C2=A0 the version in port to be sure to have the right version on a= ll<br> =C2=A0 =C2=A0 supported versions of the ports tree)<br> <br> =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 Herbert J. Skuhra" <<a href= =3D"mailto:herbert@gojira.at" target=3D"_blank">herbert@gojira.at</a>><b= r> ---<br> =C2=A0Mk/Scripts/dialog4ports.sh | 4 ++--<br> =C2=A0Mk/<a href=3D"http://bsd.commands.mk" rel=3D"noreferrer" target=3D"_b= lank">bsd.commands.mk</a>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 2 +-<br> =C2=A02 files changed, 3 insertions(+), 3 deletions(-)<br> <br> diff --git a/Mk/Scripts/dialog4ports.sh b/Mk/Scripts/dialog4ports.sh<br> index e229d7d4bdc1..de62a91b583f 100644<br> --- a/Mk/Scripts/dialog4ports.sh<br> +++ b/Mk/Scripts/dialog4ports.sh<br> @@ -10,8 +10,8 @@ if [ -z "${DIALOG4PORTS}" -o -z "${PORTSDI= R}" -o -z "${MAKE}" ]; then<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 exit 1<br> =C2=A0fi<br> <br> -: ${DIALOGPORT:=3Dports-mgmt/dialog4ports}<br> -: ${DIALOGNAME:=3Ddialog4ports}<br> +: ${DIALOGPORT:=3Dports-mgmt/portconfig}<br> +: ${DIALOGNAME:=3Dportconfig}<br> <br> =C2=A0OPTIONSFILE=3D"$1"<br> <br> diff --git a/Mk/<a href=3D"http://bsd.commands.mk" rel=3D"noreferrer" targe= t=3D"_blank">bsd.commands.mk</a> b/Mk/<a href=3D"http://bsd.commands.mk" re= l=3D"noreferrer" target=3D"_blank">bsd.commands.mk</a><br> index 7addad889763..636f2f2f481e 100644<br> --- a/Mk/<a href=3D"http://bsd.commands.mk" rel=3D"noreferrer" target=3D"_b= lank">bsd.commands.mk</a><br> +++ b/Mk/<a href=3D"http://bsd.commands.mk" rel=3D"noreferrer" target=3D"_b= lank">bsd.commands.mk</a><br> @@ -33,7 +33,7 @@ DIALOG?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 /usr/bin/dialog<br> =C2=A0.else<br> =C2=A0DIALOG?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/usr= /bin/bsddialog<br> =C2=A0.endif<br> -DIALOG4PORTS?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${LOCALBASE}/bin/dialog4= ports<br> +DIALOG4PORTS?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${LOCALBASE}/bin/portcon= fig<br> =C2=A0DIFF?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0/usr/bin/diff<br> =C2=A0DIRNAME?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /usr/bin/= dirname<br> =C2=A0EGREP?=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 /usr/bin/egrep<br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><div><div dir=3D"ltr"><div>Adam Weinberger</div><div><a href=3D"mailto:= adamw@adamw.org" target=3D"_blank">adamw@adamw.org</a></div><div><a href=3D= "https://www.adamw.org" target=3D"_blank">https://www.adamw.org</a></div></= div></div></div></div> --000000000000d799c2060766d355--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcgj%2B6FgurdRpruoRsqCExq8rOqPOFaUbsJN1KSydR7t9Q>