Date: Tue, 10 Oct 2023 21:34:26 -0400 From: Adam Weinberger <adamw@adamw.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 0e73ed9372f0 - main - config: switch from dialog4ports to portconfig Message-ID: <CAP7rwcgj%2B6FgurdRpruoRsqCExq8rOqPOFaUbsJN1KSydR7t9Q@mail.gmail.com> In-Reply-To: <202310101158.39ABwYv1037813@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi Baptiste, The DIALOG4PORTS option from poudriere probably needs to be switched to a PORTCONFIG option. # Adam On Tue, Oct 10, 2023 at 7:58 AM Baptiste Daroussin <bapt@freebsd.org> wrote: > The branch main has been updated by bapt: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=0e73ed9372f074ba59d40b66b95c878a7f36702e > > commit 0e73ed9372f074ba59d40b66b95c878a7f36702e > Author: Baptiste Daroussin <bapt@FreeBSD.org> > AuthorDate: 2023-10-10 11:53:44 +0000 > Commit: Baptiste Daroussin <bapt@FreeBSD.org> > CommitDate: 2023-10-10 11:58:31 +0000 > > config: switch from dialog4ports to portconfig > > dialog4ports is using libdialog which is being decommissioned from > base replaced by bsddialog. We cannot switch to depending on > devel/cdialog because it build depends on too many things, on the other > hand the author of bsddialog made portconfig as a drop-in replacement > for dialog4ports, it only build depends on devel/bsddialog (we use > the version in port to be sure to have the right version on all > supported versions of the ports tree) > > Reported by: Herbert J. Skuhra" <herbert@gojira.at> > --- > Mk/Scripts/dialog4ports.sh | 4 ++-- > Mk/bsd.commands.mk | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Mk/Scripts/dialog4ports.sh b/Mk/Scripts/dialog4ports.sh > index e229d7d4bdc1..de62a91b583f 100644 > --- a/Mk/Scripts/dialog4ports.sh > +++ b/Mk/Scripts/dialog4ports.sh > @@ -10,8 +10,8 @@ if [ -z "${DIALOG4PORTS}" -o -z "${PORTSDIR}" -o -z > "${MAKE}" ]; then > exit 1 > fi > > -: ${DIALOGPORT:=ports-mgmt/dialog4ports} > -: ${DIALOGNAME:=dialog4ports} > +: ${DIALOGPORT:=ports-mgmt/portconfig} > +: ${DIALOGNAME:=portconfig} > > OPTIONSFILE="$1" > > diff --git a/Mk/bsd.commands.mk b/Mk/bsd.commands.mk > index 7addad889763..636f2f2f481e 100644 > --- a/Mk/bsd.commands.mk > +++ b/Mk/bsd.commands.mk > @@ -33,7 +33,7 @@ DIALOG?= /usr/bin/dialog > .else > DIALOG?= /usr/bin/bsddialog > .endif > -DIALOG4PORTS?= ${LOCALBASE}/bin/dialog4ports > +DIALOG4PORTS?= ${LOCALBASE}/bin/portconfig > DIFF?= /usr/bin/diff > DIRNAME?= /usr/bin/dirname > EGREP?= /usr/bin/egrep > -- Adam Weinberger adamw@adamw.org https://www.adamw.org [-- Attachment #2 --] <div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif">Hi Baptiste,</div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,sans-serif">The DIALOG4PORTS option from poudriere probably needs to be switched to a PORTCONFIG option.</div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,sans-serif"># Adam</div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 10, 2023 at 7:58 AM Baptiste Daroussin <<a href="mailto:bapt@freebsd.org">bapt@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by bapt:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=0e73ed9372f074ba59d40b66b95c878a7f36702e" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=0e73ed9372f074ba59d40b66b95c878a7f36702e</a><br>; <br> commit 0e73ed9372f074ba59d40b66b95c878a7f36702e<br> Author: Baptiste Daroussin <bapt@FreeBSD.org><br> AuthorDate: 2023-10-10 11:53:44 +0000<br> Commit: Baptiste Daroussin <bapt@FreeBSD.org><br> CommitDate: 2023-10-10 11:58:31 +0000<br> <br> config: switch from dialog4ports to portconfig<br> <br> dialog4ports is using libdialog which is being decommissioned from<br> base replaced by bsddialog. We cannot switch to depending on<br> devel/cdialog because it build depends on too many things, on the other<br> hand the author of bsddialog made portconfig as a drop-in replacement<br> for dialog4ports, it only build depends on devel/bsddialog (we use<br> the version in port to be sure to have the right version on all<br> supported versions of the ports tree)<br> <br> Reported by: Herbert J. Skuhra" <<a href="mailto:herbert@gojira.at" target="_blank">herbert@gojira.at</a>><br> ---<br> Mk/Scripts/dialog4ports.sh | 4 ++--<br> Mk/<a href="http://bsd.commands.mk" rel="noreferrer" target="_blank">bsd.commands.mk</a> | 2 +-<br> 2 files changed, 3 insertions(+), 3 deletions(-)<br> <br> diff --git a/Mk/Scripts/dialog4ports.sh b/Mk/Scripts/dialog4ports.sh<br> index e229d7d4bdc1..de62a91b583f 100644<br> --- a/Mk/Scripts/dialog4ports.sh<br> +++ b/Mk/Scripts/dialog4ports.sh<br> @@ -10,8 +10,8 @@ if [ -z "${DIALOG4PORTS}" -o -z "${PORTSDIR}" -o -z "${MAKE}" ]; then<br> exit 1<br> fi<br> <br> -: ${DIALOGPORT:=ports-mgmt/dialog4ports}<br> -: ${DIALOGNAME:=dialog4ports}<br> +: ${DIALOGPORT:=ports-mgmt/portconfig}<br> +: ${DIALOGNAME:=portconfig}<br> <br> OPTIONSFILE="$1"<br> <br> diff --git a/Mk/<a href="http://bsd.commands.mk" rel="noreferrer" target="_blank">bsd.commands.mk</a> b/Mk/<a href="http://bsd.commands.mk" rel="noreferrer" target="_blank">bsd.commands.mk</a><br> index 7addad889763..636f2f2f481e 100644<br> --- a/Mk/<a href="http://bsd.commands.mk" rel="noreferrer" target="_blank">bsd.commands.mk</a><br> +++ b/Mk/<a href="http://bsd.commands.mk" rel="noreferrer" target="_blank">bsd.commands.mk</a><br> @@ -33,7 +33,7 @@ DIALOG?= /usr/bin/dialog<br> .else<br> DIALOG?= /usr/bin/bsddialog<br> .endif<br> -DIALOG4PORTS?= ${LOCALBASE}/bin/dialog4ports<br> +DIALOG4PORTS?= ${LOCALBASE}/bin/portconfig<br> DIFF?= /usr/bin/diff<br> DIRNAME?= /usr/bin/dirname<br> EGREP?= /usr/bin/egrep<br> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Adam Weinberger</div><div><a href="mailto:adamw@adamw.org" target="_blank">adamw@adamw.org</a></div><div><a href="https://www.adamw.org" target="_blank">https://www.adamw.org</a></div></div></div></div></div>;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAP7rwcgj%2B6FgurdRpruoRsqCExq8rOqPOFaUbsJN1KSydR7t9Q>