Date: Sun, 30 Dec 2007 13:53:17 GMT From: Hans Petter Selasky <hselasky@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 132095 for review Message-ID: <200712301353.lBUDrHxK073450@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=132095 Change 132095 by hselasky@hselasky_laptop001 on 2007/12/30 13:53:16 Get rid if inlining. These functions are not time critical. Affected files ... .. //depot/projects/usb/src/sys/dev/usb/uchcom.c#5 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/uchcom.c#5 (text+ko) ==== @@ -398,7 +398,7 @@ * low level i/o */ -static __inline usbd_status +static usbd_status uchcom_ctrl_write(struct uchcom_softc *sc, uint8_t reqno, uint16_t value, uint16_t index) { @@ -413,7 +413,7 @@ return usbd_do_request(sc->sc_ucom.sc_udev, &req, 0); } -static __inline usbd_status +static usbd_status uchcom_ctrl_read(struct uchcom_softc *sc, uint8_t reqno, uint16_t value, uint16_t index, void *buf, int buflen, int *actlen) @@ -431,7 +431,7 @@ USBD_DEFAULT_TIMEOUT); } -static __inline usbd_status +static usbd_status uchcom_write_reg(struct uchcom_softc *sc, uint8_t reg1, uint8_t val1, uint8_t reg2, uint8_t val2) { @@ -443,7 +443,7 @@ reg1|((uint16_t)reg2<<8), val1|((uint16_t)val2<<8)); } -static __inline usbd_status +static usbd_status uchcom_read_reg(struct uchcom_softc *sc, uint8_t reg1, uint8_t *rval1, uint8_t reg2, uint8_t *rval2) { @@ -467,7 +467,7 @@ return USBD_NORMAL_COMPLETION; } -static __inline usbd_status +static usbd_status get_version(struct uchcom_softc *sc, uint8_t *rver) { uint8_t buf[UCHCOM_INPUT_BUF_SIZE]; @@ -484,19 +484,19 @@ return USBD_NORMAL_COMPLETION; } -static __inline usbd_status +static usbd_status uchcom_get_status(struct uchcom_softc *sc, uint8_t *rval) { return uchcom_read_reg(sc, UCHCOM_REG_STAT1, rval, UCHCOM_REG_STAT2, NULL); } -static __inline usbd_status +static usbd_status uchcom_set_dtrrts_10(struct uchcom_softc *sc, uint8_t val) { return uchcom_write_reg(sc, UCHCOM_REG_STAT1, val, UCHCOM_REG_STAT1, val); } -static __inline usbd_status +static usbd_status uchcom_set_dtrrts_20(struct uchcom_softc *sc, uint8_t val) { return uchcom_ctrl_write(sc, UCHCOM_REQ_SET_DTRRTS, val, 0);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712301353.lBUDrHxK073450>