Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Dec 2025 18:40:20 -0800
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        Cy Schubert <cy@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   Re: git: 1b96cdea82c7 - stable/15 - ipfilter: Add missing kenv  fetch
Message-ID:  <20251219024020.D5F4221E@slippy.cwsent.com>
In-Reply-To: <909a8fcd-158a-4b7c-a730-a45516662a83@FreeBSD.org>
References:  <69449ba5.2386e.1363dce8@gitrepo.freebsd.org>  <909a8fcd-158a-4b7c-a730-a45516662a83@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

In message <909a8fcd-158a-4b7c-a730-a45516662a83@FreeBSD.org>, John Baldwin 
wri
tes:
> On 12/18/25 19:26, Cy Schubert wrote:
> > The branch stable/15 has been updated by cy:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=1b96cdea82c77191fb4e777ab63428
> de95f56d3b
> > 
> > commit 1b96cdea82c77191fb4e777ab63428de95f56d3b
> > Author:     Cy Schubert <cy@FreeBSD.org>
> > AuthorDate: 2025-12-15 16:21:56 +0000
> > Commit:     Cy Schubert <cy@FreeBSD.org>
> > CommitDate: 2025-12-19 00:26:07 +0000
> > 
> >      ipfilter: Add missing kenv fetch
> >      
> >      When a module the environment must be explicitly fetched.
> >      
> >      Fixes:                  d9788eabffa4
> >      PR:                     291548
> >      Noted by:               markj
> >      Reviewed by:            markj
> >      Differential Revision:  https://reviews.freebsd.org/D54242
> >      MFC after:              3 days
> >      (cherry picked from commit a6ea80bc917510b5e056cc5a29b62dfd7b39d068)
>
> This doesn't build on either stable/15 or stable/14:
>
> /usr/src/sys/netpfil/ipfilter/netinet/ip_fil_freebsd.c:1461:11: error: no mem
> ber named 'ipf_jail_allowed' in 'struct ipf_main_softc_s'
>   1461 |                 &softc->ipf_jail_allowed);
>        |                  ~~~~~  ^
> /usr/src/sys/sys/kernel.h:334:58: note: expanded from macro 'TUNABLE_INT_FETC
> H'
>    334 | #define TUNABLE_INT_FETCH(path, var)    getenv_int((path), (var))
>        |                                                             ^~~
> 1 error generated.
> *** [ip_fil_freebsd.o] Error code 1
>
> -- 
> John Baldwin


I should have merged d9788eabffa4b67fc534685fc3d9b8e3334af196 before this 
one. I've backed them out in order to apply the prerequisite first.

Sorry for the breakage.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e**(i*pi)+1=0




help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20251219024020.D5F4221E>