Date: Sun, 31 Jul 2011 15:57:01 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@spoerlein.net> To: d@delphij.net Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: weekly_catman not generating the right result? Message-ID: <20110731135700.GC11991@acme.spoerlein.net> In-Reply-To: <4E354DFB.1020206@delphij.net> References: <4E3510CC.8090300@delphij.net> <20110731121732.GB11991@acme.spoerlein.net> <4E354DFB.1020206@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Qbvjkv9qwOGw/5Fx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, 2011-07-31 at 05:43:39 -0700, Xin LI wrote: > On 07/31/11 05:17, Ulrich Sp=C3=B6rlein wrote: > > On Sun, 2011-07-31 at 01:22:36 -0700, Xin LI wrote: > >> Hi, > >>=20 > >> I just noticed that weekly_catman is not generating the right > >> result, e.g. instead of a highlight NAME, it gives 1mNAME0m (looks > >> like the escape character is missing here). > >>=20 > >> Is this a known issue? > >=20 > > Now it is :) > >=20 > > This is due to the recent changes that made groff emit ANSI > > sequences and catman(1) is still putting col(1) in the pipe, which is > > not really required and gobbles up part of the escape sequences. > >=20 > > Please try the attached patch. Thanks. >=20 > Thanks, that fixes the problem. >=20 > Note that I noticed that setting PAGER to less won't work. Looking at > my 8.2-RELEASE system, the rendered catpages are using ^H when > highlighting while on -CURRENT it's an escape sequence (but I didn't see > any change to nroff script nor catman itself)... The change that did this is r222648. You'll need to use `less -Rs' as your PAGER/MANPAGER (or export LESS=3D-Rs). It's debatable if we want catpages to retain the old way of marking up bold and underlined text. Ruslan: bsd.doc.mk was told to not use SGR in r222647, does it make sense to do the same for catpages? Uli --Qbvjkv9qwOGw/5Fx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iQEcBAEBAgAGBQJONV8sAAoJEKOmmGRKr4LOAekH/3VTFQripKzPjS53zyodDWnF vfrlPefG3ve6mYHWmx2DfOrrGWljBEIFr0sNhU/sR8mqpqXem8AIFzvqjwdyM3jv 5jb2bUK4nnR0lNjDDqrFScKZZXa3c/mpXfF+0tXqMjnIw6blPXEbsRYdJgCEufyR LyWVazWS6cBVCORwQx2qrPmXJ4FRcDPHnlELcuFmUG8Esein1Jwfotb8TzU34VVO gWHyz2RTuxaCc0Qu1IME2mEpAv8Y8CXSQO/3Py8s59PjxWyPc1RkTlbGHlbOi6aR 4OMmLdTW2RAOU57JvBUFuSJ8QBEX+6YSbijIwZnt9fqKu+vAF1mty3E4Id35vCc= =PcJO -----END PGP SIGNATURE----- --Qbvjkv9qwOGw/5Fx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110731135700.GC11991>