Date: Tue, 19 May 1998 18:28:46 +0300 (EEST) From: Ruslan Ermilov <ru@ucb.crimea.ua> To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: bin/6690: ppp doesn't close socket in CleanInterface() Message-ID: <199805191528.SAA26629@relay.ucb.crimea.ua>
index | next in thread | raw e-mail
>Number: 6690
>Category: bin
>Synopsis: ppp doesn't close socket in CleanInterface()
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue May 19 08:30:02 PDT 1998
>Last-Modified:
>Originator: Ruslan Ermilov
>Organization:
United Commercial Bank
>Release: FreeBSD 2.2.6-STABLE i386
>Environment:
-stable as of today
>Description:
Socket is opened and not closed in CleanInterface()
>How-To-Repeat:
Run ``ppp -direct'' (don't know if this affects other modes),
and run ``fstat -p <pid>''.
>Fix:
Apply the following patch:
Index: os.c
===================================================================
RCS file: /usr/FreeBSD-CVS/src/usr.sbin/ppp/os.c,v
retrieving revision 1.7.2.16
diff -u -r1.7.2.16 os.c
--- os.c 1998/01/26 20:05:04 1.7.2.16
+++ os.c 1998/05/19 15:15:53
@@ -183,6 +183,7 @@
LogPrintf(LogERROR, "tun_configure: Can't get dst for %s on %s !\n",
inet_ntoa(((struct sockaddr_in *)&ifra.ifra_addr)->sin_addr),
name);
+ close(s);
return 0;
}
ifra.ifra_broadaddr = ifrq.ifr_dstaddr;
@@ -191,10 +192,12 @@
LogPrintf(LogERROR, "tun_configure: Can't delete %s address on %s !\n",
inet_ntoa(((struct sockaddr_in *)&ifra.ifra_addr)->sin_addr),
name);
+ close(s);
return 0;
}
}
+ close(s);
return 1;
}
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805191528.SAA26629>