Date: Sun, 9 Jul 1995 20:31:27 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: candy@fct.kgc.co.jp Cc: freebsd-bugs@freefall.cdrom.com Subject: Re: bin/606: tcpdump(1) doesn't show appletalk packets correctly Message-ID: <199507100331.UAA10521@gndrsh.aac.dev.com> In-Reply-To: <199507100320.UAA23960@freefall.cdrom.com> from "Toshihiro Kanda" at Jul 9, 95 08:20:03 pm
index | next in thread | previous in thread | raw e-mail
Visial first pass review spots a new bug introduced by this patch,
please verify...
>
>
> >Number: 606
> >Category: bin
> >Synopsis: tcpdump(1) doesn't show appletalk packets correctly
...
> *** /usr/src/usr.sbin/tcpdump/tcpdump/print-ether.c Wed Oct 5 07:31:44 1994
> --- tcpdump/tcpdump/print-ether.c Mon Jul 10 11:02:56 1995
> ***************
> *** 122,128 ****
> && lp->llc_snap_oui[1] == 0x00
> && lp->llc_snap_oui[2] == 0x07) {
> printf("[ethertalk] ");
> ! ddp_print((struct atDDP *)((char *)lp + 6),
> length - 6);
> } else {
> if(!eflag) {
> --- 122,128 ----
> && lp->llc_snap_oui[1] == 0x00
> && lp->llc_snap_oui[2] == 0x07) {
> printf("[ethertalk] ");
> ! ddp_print((struct atDDP *)((char *)lp + 8),
> length - 6);
Should that now not also be ``length - 8'') :-)
--
Rod Grimes rgrimes@gndrsh.aac.dev.com
Accurate Automation Company Reliable computers for FreeBSD
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199507100331.UAA10521>