Date: Thu, 22 Apr 2021 12:10:26 +0200 From: Michael Gmelin <grembo@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: <FB32E75F-9AF0-41C2-9EE1-B10D931DECD0@freebsd.org> In-Reply-To: <YIFK/tIpcfqWTWVh@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
> On 22. Apr 2021, at 12:08, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>
> On Thu, Apr 22, 2021 at 09:52:19AM +0000, Mathieu Arnold wrote:
>> ...
>> diff --git a/.hooks/prepare-commit-msg b/.hooks/prepare-commit-msg
>> @@ -44,6 +44,9 @@ $(awk '1;/^#$/{exit}' "$1")
>> # <then a blank line>
>> # 72 columns --|
>> #
>> +# Do not add a Submitted by line. If someone besides the committer sent in the
>> +# change, the commit author should be set using \`git commit --author\`.
>> +#
>
> This doesn't seem right. "Submitted by" can be a list, not a single name.
> Also, I rarely commit submitted work verbatim, so technically the author
> is me 99% of the time, yet it would be appropriate to give attribution to
> the original submitter, esp. if there is no PR number (private submission).
>
I agree that author should only be used if a submission is applied unaltered (pull request/git patch).
-m
> ./danfe
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FB32E75F-9AF0-41C2-9EE1-B10D931DECD0>