Date: Sat, 26 Jan 2019 15:11:52 -0800 From: Mel Pilgrim <list_freebsd@bluerosetech.com> To: Hans Petter Selasky <hps@selasky.org>, freebsd-current@freebsd.org, freebsd-usb@freebsd.org Subject: Re: usb/234503 already committed, but needs modification to cover more devices Message-ID: <206f6f49-9a00-b100-d503-cfff6092ffdb@bluerosetech.com> In-Reply-To: <6c72d9bf-84ab-a9e7-598d-48f6301fa291@selasky.org> References: <3f9936d7-14ba-c820-3fe5-f767d968e52f@bluerosetech.com> <6c72d9bf-84ab-a9e7-598d-48f6301fa291@selasky.org>
index | next in thread | previous in thread | raw e-mail
On 01/26/2019 01:24, Hans Petter Selasky wrote: > On 1/26/19 1:41 AM, Mel Pilgrim wrote: >> A quirk for a USB flashdrive was added to head (r342657), but the >> modification was too narrow. The quirk affects all of the devices >> in the Chipfancier SLC family, not just the one specific device for >> which the quirk was added. >> >> I replied to usb/234503 about this, but as this is already in head, >> I'd like someone to act on it and modify the quirk to cover all of >> the devices in the family before 12.0-R comes out (and hopefully >> MFC to stable before 11.3 comes out). >> >> As I wrote in the PR, I'm already running the patch in releng/11.2 >> in production. > > It is not a problem to make a patch to ignore the idProduct field > when matching. Will you make a patch for usb_quirk.c ? I can do up a patch, yes. The subject file thus far is scsi_da.c, not usb_quirk.c? I'm not sure how to make a quirk that is idProduct agnostic. Is there documentation on this, or can you point me an example of such an entry?help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?206f6f49-9a00-b100-d503-cfff6092ffdb>