Date: Thu, 10 Mar 2016 14:37:33 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296589 - head/sys/dev/fdc Message-ID: <56E1F72D.7000002@FreeBSD.org> In-Reply-To: <201603100033.u2A0X6uN027771@repo.freebsd.org> References: <201603100033.u2A0X6uN027771@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3/9/16 4:33 PM, Warner Losh wrote: > Author: imp > Date: Thu Mar 10 00:33:06 2016 > New Revision: 296589 > URL: https://svnweb.freebsd.org/changeset/base/296589 > > Log: > Stop assuming that bio_cmd is a bit field. > > Differential Revision: https://reviews.freebsd.org/D5587 > > Modified: > head/sys/dev/fdc/fdc.c > > Modified: head/sys/dev/fdc/fdc.c > ============================================================================== > --- head/sys/dev/fdc/fdc.c Thu Mar 10 00:27:10 2016 (r296588) > +++ head/sys/dev/fdc/fdc.c Thu Mar 10 00:33:06 2016 (r296589) > @@ -941,7 +941,7 @@ fdc_worker(struct fdc_data *fdc) > /* Disable ISADMA if we bailed while it was active */ > if (fd != NULL && (fd->flags & FD_ISADMA)) { > isa_dmadone( > - bp->bio_cmd & BIO_READ ? ISADMA_READ : ISADMA_WRITE, > + bp->bio_cmd == BIO_READ ? ISADMA_READ : ISADMA_WRITE, I think we should have some kind of file (like ports CHANGES) that lists subtle KPI changes. This and the bio bzero change were easily missed and could lead to who-knows-what downstream for vendors or even out-of-tree modules. Btw there are some missed still: ./dev/mfi/mfi.c: switch (bio->bio_cmd & 0x03) { ./dev/mfi/mfi.c: switch (bio->bio_cmd & 0x03) { -- Regards, Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56E1F72D.7000002>