Date: Tue, 30 Mar 2010 10:21:45 -0500 From: Barry Pederson <bp@barryp.org> To: jhell <jhell@dataix.net> Cc: FreeBSD Stable <freebsd-stable@freebsd.org> Subject: Re: ZFS Tuning - arc_summary.pl Message-ID: <4BB21709.1070101@barryp.org> In-Reply-To: <4BB20AED.70802@dataix.net> References: <cf9b1ee01002150049o43fced71ucb5776a0a1eaf4cf@mail.gmail.com> <20100215090756.GA54764@icarus.home.lan> <20100215105000.101326yj01j0f64g@webmail.leidinger.net> <20100215122744.GA57382@icarus.home.lan> <20100215161105.14071eiflhc9le68@webmail.leidinger.net> <4B79BA9C.3020402@quip.cz> <alpine.BSF.2.00.1002152024040.74553@pragry.qngnvk.ybpny> <4B7AD0A3.9080701@barryp.org> <alpine.BSF.2.00.1002170321200.14189@pragry.qngnvk.ybpny> <4BB0BC7C.3000801@barryp.org> <4BB20AED.70802@dataix.net>
index | next in thread | previous in thread | raw e-mail
On 3/30/10 9:30 AM, jhell wrote: > Ill mark this up on my todo. Thanks for the feedback& I should have > something committed back within the next couple days, possibly even tonight. > > I never recalculated for this difference as that area of the code was > just a formatting fix. > > But as Jeremy has pointed out, it would have to verify against > __FreeBSD_version but since I already pull in the sysctl MIB > kern.osreldate I should be able to compare to that and say 700000 or > higher make the above correction. > > As this is mainly ZFS v13 dependent now I don't feel to bad doing what I > have stated above. > > Thanks again, > > Regards, Shouldn't the "ARC Size Breakdown" be based on the current size (instead of the target size) no matter what? If the current size was *less* than arc_max, you'd also get an nonsensical breakdown - in that case with the "recently used" and "frequently used" adding up to *more* than the current size. It seems to me that the only thing that would be different between newer and older FreeBSD version would be whether arc_max would be described as a "Hard Limit" or not - which is maybe not that important to show. If that's all true, then the patch should work for both older and newer versions of FreeBSD. Barryhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BB21709.1070101>