Date: Tue, 4 Jun 2019 08:58:43 -0600 From: Warner Losh <imp@bsdimp.com> To: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Johannes Lundberg <johalun@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: UEFI boot broken in 13? Message-ID: <CANCZdfo0s3UNRa3BYCCrnS7yCEhf3ikFdj=15yxQc3qhoVXoWQ@mail.gmail.com> In-Reply-To: <CANCZdfrh4XP0WJK65w2RjmvV4VLsZswYKR-EoJ-suvdLc4LaPg@mail.gmail.com> References: <71a0c9f7-0b1f-3757-fc04-4c0d0a1e1085@FreeBSD.org> <20190604212831.360fd1a0c34c9f329e3084fc@dec.sakura.ne.jp> <CANCZdfrh4XP0WJK65w2RjmvV4VLsZswYKR-EoJ-suvdLc4LaPg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 4, 2019 at 8:16 AM Warner Losh <imp@bsdimp.com> wrote: > > > On Tue, Jun 4, 2019 at 7:11 AM Tomoaki AOKI <junchoon@dec.sakura.ne.jp> > wrote: > >> Hi. >> >> Try attached patch for stand/efi/boot1/boot1.c. >> This partially reverts r347193 and works at least for me. >> >> Without this, boot1.efi (bootx64.efi) forcibly boot from >> first physical HDD/SSD, even if forcibly booted from other >> physical drive via BIOS (UEFI firmware) menu. >> >> Remaining parts of >> https://reviews.freebsd.org/D20513https://reviews.freebsd.org/D20513 and >> following some commits does not >> affect. >> >> *Hand-crafted reverse patch from commit mail [1]. >> Reverting whole r347193 is fine, too. >> >> [1] >> https://lists.freebsd.org/pipermail/svn-src-head/2019-May/124677.html > > > I'll take a look. My experience is that even prior to this patch, forcibly > booting also failed though due to ordering issues... > More testing reveals that the issues prior to r347193 turned out to be different, and r347193 really did break things. I've opted to fix this in a slightly different way: https://reviews.freebsd.org/D20513 Aoki-san, can you please check to see if the above review fixes things for you as well? Thanks! Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo0s3UNRa3BYCCrnS7yCEhf3ikFdj=15yxQc3qhoVXoWQ>