Date: Wed, 19 Dec 2001 11:16:41 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Josef Karthauser <joe@tao.org.uk>, freebsd-current@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c vfs_vnops.c src/sys/sys Message-ID: <XFMail.011219111641.jhb@FreeBSD.org> In-Reply-To: <200112191913.fBJJDBu90110@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19-Dec-01 Matthew Dillon wrote: >:> The structure is being bzero()'d before its dynamic flag gets checked. >:> I've included a patch below. Josef, I would appreciate it if you would >:> apply the patch and try your system with the various procfs devices >:> mounted again. It's an obvious bug so I'm comitting it to -current >:> now, >:> the question is: Is it the *only* bug? >:> >:> -Matt >: >:Hmm, why bzero at all if you are just going to free it? Why not move the >:bzero >:to an else after the ISDYNSTRUCT check? (Not that this is really all that >:important, but... :) >: >:-- >: >:John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ > > He is invalidating the structure to catch references to deleted sbufs. > (see assert_sbuf_integrity() calls). Fair enough. In theory an INVARIANTS kernel with 0xdeadc0de should do that for you though. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011219111641.jhb>