Date: Sat, 7 Apr 2007 18:54:35 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/sys/sys unistd.h Message-ID: <20070407165435.GK63916@garage.freebsd.pl> In-Reply-To: <20070407164022.GA10309@nagual.pp.ru> References: <200704071602.l37G2V1c066806@repoman.freebsd.org> <20070407164022.GA10309@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--q6mBvMCt6oafMx9a
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Apr 07, 2007 at 08:40:22PM +0400, Andrey Chernov wrote:
> On Sat, Apr 07, 2007 at 04:02:31PM +0000, Pawel Jakub Dawidek wrote:
> > - Only define SEEK_DATA and SEEK_HOLE in sys/unistd.h when neither
> > _POSIX_SOURCE nor _XOPEN_SOURCE is defined.
>=20
> 1) This new addition should be exluded for !define(_C99_SOURCE)
> !define(_ANSI_SOURCE) !define(_POSIX_C_SOURCE) too.
>=20
> 2) We design our *_VISIBLE framework right for the reason to not mention=
=20
> all possible *_SOURCE each time like this, making includes unnecessary bi=
g=20
> and hard to adapt to the future *_SOURCE tags, but mention one *_VISIBLE=
=20
> tag instead, so please rewrite this thing using it.
That's why I asked for help. _CDDL_VISIBLE is not good, because it is
not related to CDDL license. _ZFS_VISIBLE is not good, because it is not
ZFS-specific. _{SUN,SOLARIS,OPENSOLARIS}_VISIBLE is also not good,
because it is already in Linux too. Solaris simply defines
__EXTENSIONS__. Maybe we need something like this? I don't think we need
separate _*_VISIBLE defines for every new #define in unistd.h and other
headers, so something similar to __EXTENSIONS__ makes sense to me.
--=20
Pawel Jakub Dawidek http://www.wheel.pl
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
--q6mBvMCt6oafMx9a
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)
iD8DBQFGF8zLForvXbEpPzQRAiyYAKDkNB51ETQ4NaEcTkGToqAa9pr5RwCcD9Nl
lGdLgmRF+BD+gPHeM2e6I3Y=
=ci5B
-----END PGP SIGNATURE-----
--q6mBvMCt6oafMx9a--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070407165435.GK63916>