Date: Fri, 6 Feb 2015 21:23:47 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: James Gritton <jamie@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, jenkins-admin@freebsd.org Subject: Re: svn commit: r278323 - in head: etc/rc.d usr.sbin/jail Message-ID: <D394178A-1710-4863-BC88-07E4ABC479CD@gmail.com> In-Reply-To: <d47729eeee3fc3725dedaeb4e4e4fb3c@gritton.org> References: <201502061754.t16HssXU042750@svn.freebsd.org> <343803A3-CFA3-4766-8294-139A6D8C0235@gmail.com> <d47729eeee3fc3725dedaeb4e4e4fb3c@gritton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_BBABA529-F1EE-44BE-A4C1-84BFD08D3E25 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Feb 6, 2015, at 18:38, James Gritton <jamie@freebsd.org> wrote: > On 2015-02-06 19:23, Garrett Cooper wrote: >> On Feb 6, 2015, at 9:54, Jamie Gritton <jamie@freebsd.org> wrote: >>> Author: jamie >>> Date: Fri Feb 6 17:54:53 2015 >>> New Revision: 278323 >>> URL: https://svnweb.freebsd.org/changeset/base/278323 >>> Log: >>> Add mount.procfs jail parameter, so procfs can be mounted when a = prison's >>> root is in its fstab. >>> Also fix a typo while I'm at it. >>> PR: 197237 197066 >>> MFC after: 3 days >>> Modified: >>> head/etc/rc.d/jail >>> head/usr.sbin/jail/command.c >>> head/usr.sbin/jail/config.c >>> head/usr.sbin/jail/jail.8 >>> head/usr.sbin/jail/jail.c >>> head/usr.sbin/jail/jailp.h >> I think you broke the Jenkins tests runs, and potentially jail = support >> in some edgecases: >> https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests2/651/ >=20 > Where do I go from here? There error you refer to certainly seems = jail-related, which leads me to guess at something disconnected between = the matching rc.d/jail and jail(8) change (i.e. using the new rc file = with the old jail program). But that's really just a wild guess. Is = there somewhere I look for more information? For example, where does = Jenkins actually do its thing? >=20 > Sorry for being so stupid in this - Jenkins has only been on the very = edge of my awareness until now. I honestly don=92t think it=92s Jenkins because Jenkins runs in bhyve. I = think you accidentally broke option handling in the jail configuration = (please see my other reply about added =93break;=94 statements). pgrep uses /proc to determine whether or not a process is running. If = it=92s not properly mounted or the jail isn=92t started properly, that = could cause the issues seen here. I know because I=92ve tried running = these tests before in an attempt to fix them, and this was one of the = things I ran into. You can verify your changes by doing: % (cd /usr/tests/bin/pkill; sudo kyua test) Cheers! --Apple-Mail=_BBABA529-F1EE-44BE-A4C1-84BFD08D3E25 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJU1aFjAAoJEMZr5QU6S73eXuIH/0ed5GkSgmfhXVqhi6at1hv6 F2g+49WPImwt7ZHIGhbwcyzaRC9SLRzwQp87c/NqjWhUcAoK8JUl5mQ+pmzjD1B9 UajjttxhRDCCvGTt+RYfGNCoiMexXZdOmrdaLJ4PoKQEJSK0lSKgDImHz7KmTqdH uCDrHYciLbUQA1evOf6Tu0YussW7V82lYZopBa0vICNiWunAw6A1yZlYiZNZZfgT eu6u3Yqfomtb/56K8waSYJOptaMyEsgKtNHyKD3Wk7ZgVnGtnMZp32vyLzUJ+vIE dl7XySLjvFuXiTw6PAmRoseKuZfT0HOqak7UqC++4S5EDH++lKsYb5sVXxqWXRE= =JYG/ -----END PGP SIGNATURE----- --Apple-Mail=_BBABA529-F1EE-44BE-A4C1-84BFD08D3E25--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D394178A-1710-4863-BC88-07E4ABC479CD>