Date: Mon, 30 Aug 2010 15:05:43 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: pjd@FreeBSD.org Cc: svn-src-head@FreeBSD.org, marius@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r211722 - head/cddl/lib/libzpool Message-ID: <20100830.150543.994771096126846682.imp@bsdimp.com> In-Reply-To: <20100830205814.GF1871@garage.freebsd.pl> References: <201008232204.o7NM4UPA054870@svn.freebsd.org> <20100823.173600.180924398998066421.imp@bsdimp.com> <20100830205814.GF1871@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20100830205814.GF1871@garage.freebsd.pl>
Pawel Jakub Dawidek <pjd@FreeBSD.org> writes:
: On Mon, Aug 23, 2010 at 05:36:00PM -0600, M. Warner Losh wrote:
: > In message: <201008232204.o7NM4UPA054870@svn.freebsd.org>
: > Marius Strobl <marius@freebsd.org> writes:
: > : Author: marius
: > : Date: Mon Aug 23 22:04:30 2010
: > : New Revision: 211722
: > : URL: http://svn.freebsd.org/changeset/base/211722
: > :
: > : Log:
: > : Use real atomic operations for sparc64.
: > :
: > : MFC after: 1 week
: > :
: > : Modified:
: > : head/cddl/lib/libzpool/Makefile
: > :
: > : Modified: head/cddl/lib/libzpool/Makefile
: > : ==============================================================================
: > : --- head/cddl/lib/libzpool/Makefile Mon Aug 23 21:40:03 2010 (r211721)
: > : +++ head/cddl/lib/libzpool/Makefile Mon Aug 23 22:04:30 2010 (r211722)
: > : @@ -11,7 +11,7 @@
: > : # LIST_SRCS
: > : .PATH: ${.CURDIR}/../../../sys/cddl/contrib/opensolaris/uts/common/os
: > : # ATOMIC_SRCS
: > : -.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "ia64" || ${MACHINE_ARCH} == "powerpc64"
: > : +.if ${MACHINE_ARCH} == "i386" || ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "ia64" || ${MACHINE_ARCH} == "sparc64" || ${MACHINE_ARCH} == "powerpc64"
: > : .PATH: ${.CURDIR}/../../../sys/cddl/contrib/opensolaris/common/atomic/${MACHINE_ARCH}
: > : ATOMIC_SRCS= opensolaris_atomic.S
: > : .else
: >
: > I find it disturbing that we have 3 or 4 copies of this code in our
: > Makefiles...
:
: Then you will like @183089 :)
Yea, I have something very similar in my TBEMD branch... :)
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100830.150543.994771096126846682.imp>