Date: Mon, 25 Jun 2018 14:43:08 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335632 - in head/sys: dev/vt/hw/vga x86/include x86/isa x86/x86 Message-ID: <20180625114308.GD2430@kib.kiev.ua> In-Reply-To: <197a8c03-b27f-0ebb-7ce6-39a7392d5192@FreeBSD.org> References: <201806251101.w5PB1CH0008674@repo.freebsd.org> <197a8c03-b27f-0ebb-7ce6-39a7392d5192@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 25, 2018 at 02:22:30PM +0300, Andriy Gapon wrote: > On 25/06/2018 14:01, Konstantin Belousov wrote: > > Modified: head/sys/x86/x86/cpu_machdep.c > > ============================================================================== > > --- head/sys/x86/x86/cpu_machdep.c Mon Jun 25 10:52:41 2018 (r335631) > > +++ head/sys/x86/x86/cpu_machdep.c Mon Jun 25 11:01:12 2018 (r335632) > > Maybe acpi_machdep.c or some other file under x86/acpica would be better... I do not want to create a file for single 10-line function. I considered it and decided that this is silly. If you have plans for the other content, then sys/x86/acpi/acpi_machdep.c or similar may be a good idea indeed.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180625114308.GD2430>