Date: Sat, 29 Nov 2014 15:41:16 +0100 From: Hans Petter Selasky <hps@selasky.org> To: Takahashi Yoshihiro <nyan@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r275241 - head/sys/boot/pc98/boot2 Message-ID: <5479DB0C.5010208@selasky.org> In-Reply-To: <201411291222.sATCMWJv060917@svn.freebsd.org> References: <201411291222.sATCMWJv060917@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/29/14 13:22, Takahashi Yoshihiro wrote:
> + if (k = ep - arg) {
There is a missing set of parenthesis here, GCC will complain!
> } else if (c == 'S') {
> j = 0;
> - while ((unsigned int)(i = *arg++ - '0') <= 9)
> + while ((i = *arg++ - '0') <= 9)
> j = j * 10 + i;
> if (j > 0 && i == -'0') {
> comspeed = j;
Like Bruce said, this code does no longer handle negative values of "i"
like before!
BTW: If we want to squeeze more bytes out, we should consider something
like compressing the code, perhaps using something like Farbraush ??
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5479DB0C.5010208>