Date: Wed, 23 Jun 2010 23:07:57 +0000 (UTC) From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sbin/hastd ebuf.c hast_proto.c hastd.c metadata.c nv.c primary.c secondary.c Message-ID: <201006232308.o5NN8Mgf092180@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
pjd 2010-06-23 23:07:57 UTC FreeBSD src repository Modified files: (Branch: RELENG_8_1) sbin/hastd ebuf.c hast_proto.c hastd.c metadata.c nv.c primary.c secondary.c Log: SVN rev 209488 on 2010-06-23 23:07:57Z by pjd MFC r209263: r209175: Eliminate dead code. Found by: Coverity Prevent CID: 5158 r209177: Remove macros that are not really needed. The idea was to have them in case we grow more descriptors, but I'll reconsider readding them once we get there. Passing (a = b) expression to FD_ISSET() is bad idea, as FD_ISSET() evaluates its argument twice. Found by: Coverity Prevent CID: 5243 r209179: Plug memory leaks. Found by: Coverity Prevent CID: 7052, 7053, 7054, 7055 r209180: Plug memory leak. Found by: Coverity Prevent CID: 7051 r209181: Plug memory leak. Found by: Coverity Prevent CID: 7056 r209182: Plug memory leak. Found by: Coverity Prevent CID: 7057 r209183: Initialize gctl_seq for synchronization requests. Reported by: hiroshi@soupacific.com Analysed by: Mikolaj Golub <to.my.trociny@gmail.com> Tested by: hiroshi@soupacific.com, Mikolaj Golub <to.my.trociny@gmail.com> r209184: Fix typos. r209185: Correct various log messages. Submitted by: Mikolaj Golub <to.my.trociny@gmail.com> Note that without some of these changes hastd won't work on 8.x properly. Approved by: re (kensmith) Revision Changes Path 1.1.2.2.2.2 +7 -7 src/sbin/hastd/ebuf.c 1.1.2.3.2.2 +1 -3 src/sbin/hastd/hast_proto.c 1.2.2.4.2.2 +14 -22 src/sbin/hastd/hastd.c 1.1.2.3.2.2 +10 -6 src/sbin/hastd/metadata.c 1.1.2.2.2.2 +2 -0 src/sbin/hastd/nv.c 1.3.2.4.2.2 +5 -1 src/sbin/hastd/primary.c 1.1.2.3.2.2 +2 -1 src/sbin/hastd/secondary.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006232308.o5NN8Mgf092180>