Date: Sat, 29 Jan 2022 23:15:42 GMT From: Chuck Tuffli <chuck@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 45ab4076f36b - main - bhyve nvme: Remove redundant AER Limit checks Message-ID: <202201292315.20TNFgo7008230@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by chuck: URL: https://cgit.FreeBSD.org/src/commit/?id=45ab4076f36b428595ba1ce200515fda6af58a76 commit 45ab4076f36b428595ba1ce200515fda6af58a76 Author: Chuck Tuffli <chuck@FreeBSD.org> AuthorDate: 2022-01-30 07:07:29 +0000 Commit: Chuck Tuffli <chuck@FreeBSD.org> CommitDate: 2022-01-30 07:07:29 +0000 bhyve nvme: Remove redundant AER Limit checks The NVMe emulation checked if the Asynchronous Event Request Limit (a.k.a AERL) would be exceeded in pci_nvme_aer_add(), but this function is only called from nvme_opc_async_event_req() which also checks for exceeding the AERL. Reviewed by: imp, allanjude Tested by: jason@tubnor.net MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D33570 --- usr.sbin/bhyve/pci_nvme.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/usr.sbin/bhyve/pci_nvme.c b/usr.sbin/bhyve/pci_nvme.c index c9aaf86ed7be..64a6e27aa90b 100644 --- a/usr.sbin/bhyve/pci_nvme.c +++ b/usr.sbin/bhyve/pci_nvme.c @@ -744,9 +744,6 @@ pci_nvme_aer_add(struct pci_nvme_softc *sc, uint16_t cid) { struct pci_nvme_aer *aer = NULL; - if (pci_nvme_aer_limit_reached(sc)) - return (-1); - aer = calloc(1, sizeof(struct pci_nvme_aer)); if (aer == NULL) return (-1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201292315.20TNFgo7008230>