Date: Wed, 11 Feb 2015 19:18:46 +0000 From: "kostikbel (Konstantin Belousov)" <phabric-noreply@FreeBSD.org> To: freebsd-toolchain@freebsd.org Subject: [Differential] [Accepted] D1826: libdwarf: Add symbol value when processing .rela relocations Message-ID: <eb86db9c2ee3fdf45b1a77199fe48d8e@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-nmodhwpo2dxlqq7eii6c-req@FreeBSD.org> References: <differential-rev-PHID-DREV-nmodhwpo2dxlqq7eii6c-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
kostikbel accepted this revision.
kostikbel added a comment.
This revision is now accepted and ready to land.
It looks fine, but definitely is extremely subtle. The dwarf_get_reloc_size() returns zero for non-abs relocations, so dwarf_write_{m.l}sb() does nothing for other relocation types.
This at least deserves explanation in a comment.
REVISION DETAIL
https://reviews.freebsd.org/D1826
To: emaste, rpaulo, kostikbel
Cc: freebsd-toolchain
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?eb86db9c2ee3fdf45b1a77199fe48d8e>