Date: Mon, 20 Jul 2009 21:08:10 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-7@FreeBSD.org Subject: Re: svn commit: r195696 - in stable/7: crypto/openssh secure/lib/libssh Message-ID: <20090721040810.GA84807@dragon.NUXI.org> In-Reply-To: <200907142046.n6EKkJwO070823@svn.freebsd.org> References: <200907142046.n6EKkJwO070823@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 14, 2009 at 08:46:19PM +0000, John Baldwin wrote: > Date: Tue Jul 14 20:46:19 2009 > New Revision: 195696 > URL: http://svn.freebsd.org/changeset/base/195696 > Log: > MFC: Use the closefrom(2) system call. > Modified: > stable/7/crypto/openssh/ (props changed) > stable/7/crypto/openssh/config.h > stable/7/crypto/openssh/ssh_namespace.h > stable/7/secure/lib/libssh/ (props changed) > stable/7/secure/lib/libssh/Makefile Hi John, Would you mind backing out this commit from 7-stable. This change mades it so one cannot seriously boot a machine multiuser with an older kernel as /usr/sbin/sshd dies due to bad system call. I think the MFC of this part of the closefrom(2) addtion edge up against POLA for a mature -stable branch. Even in -CURRENT it's good form to add a new system call and then immedately use it... without some time laps to allow folks to boot a week old kernel. Thanks, -- David
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090721040810.GA84807>