Date: Sun, 27 Jan 2013 13:22:38 +0100 From: =?ISO-8859-1?Q?Ermal_Lu=E7i?= <eri@freebsd.org> To: Andriy Gapon <avg@freebsd.org> Cc: Nikolay Denev <ndenev@gmail.com>, "Alexander V. Chernikov" <melifaro@ipfw.ru>, freebsd-net <freebsd-net@freebsd.org> Subject: Re: ng_ether naming Message-ID: <CAPBZQG1fN992zVN27DGg7izcTDk5eMiAdTObSh1Nq9MXajuK8Q@mail.gmail.com> In-Reply-To: <51050CA5.8030805@FreeBSD.org> References: <50C9C012.8020306@FreeBSD.org> <50C9C55A.5090900@ipfw.ru> <50CA0161.1060000@FreeBSD.org> <CAPBZQG3Yo_73Ao8Ribvr2Cshii_yKfrPaJCuOGcP44fAaG1ziQ@mail.gmail.com> <50CB5B8A.8030703@FreeBSD.org> <75277A1B-B434-4220-A800-9004C29DA92A@gmail.com> <51050CA5.8030805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, it looks good, for just interface renaming scope. The problem of it is that you need to check if the ifnet pointer needs updated as well. For coming and going interfaces like vlans you would have to update some pointers as well at least the ifnet one. The complete patch would rather include moving detach/attach(?) code from if_ethersubr.c to ng_ether based on interface events. On Sun, Jan 27, 2013 at 12:16 PM, Andriy Gapon <avg@freebsd.org> wrote: > > Guys, > > based on your suggestions and submissions I've produced the following > patch: > http://people.freebsd.org/~avg/ng_ether-renaming.diff > > It's only compile-tested at the moment :) > but I'd like to get your opinion about the direction of the change(s). > I am going to really test the change very soon. > > Thank you. > > -- > Andriy Gapon > -- Ermal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPBZQG1fN992zVN27DGg7izcTDk5eMiAdTObSh1Nq9MXajuK8Q>