Date: Wed, 23 Dec 2015 03:03:57 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: Build from 9.3-RELEASE to 11.0-CURRENT fails for i386 (-Wsign-compare issues with gcc) Message-ID: <6A4DDA2E-F07D-420A-9D24-C53C2036723C@gmail.com> In-Reply-To: <E63EC242-6DDC-4ADA-A0BD-30A8B8E7841A@gmail.com> References: <8E98A82D-C36F-4863-8BE4-81288735F3A1@gmail.com> <3659799.xE9v788p8Q@ralph.baldwin.cx> <3216653.gTnkE43ffA@ralph.baldwin.cx> <E63EC242-6DDC-4ADA-A0BD-30A8B8E7841A@gmail.com>
index | next in thread | previous in thread | raw e-mail
> On Dec 22, 2015, at 10:27, Garrett Cooper <yaneurabeya@gmail.com> wrote: > > >> On Dec 22, 2015, at 08:23, John Baldwin <jhb@freebsd.org> wrote: >> >>> On Monday, December 21, 2015 11:01:36 AM John Baldwin wrote: >>>> On Saturday, December 19, 2015 01:05:36 PM NGie Cooper wrote: >>>> Hi John, >>>> I tried bootstrapping 9.3-RELEASE to 11.0-CURRENT with i386 and ran into the -Wsign-compare issue below when running make libraries with buildworld, because itfs building libkvm with gcc 4.2.1 :/c Ifve tried bootstrapping with clang/clang37, but havenft been able to yet. Ifll try installing 10.2-RELEASE via freebsd-update so I can use clang instead of gcc. >>>> Thanks! >>>> -NGie >>> >>> We don't actually support going from 9 to 11. However, these constants >>> should probably be explicitly unsigned anyway. I haven't tested this at >>> all, but something like this: >>> >>> Index: head/lib/libkvm/kvm_i386.h >>> =================================================================== >>> --- head/lib/libkvm/kvm_i386.h (revision 292553) >>> +++ head/lib/libkvm/kvm_i386.h (working copy) >>> @@ -57,8 +57,8 @@ >>> #define I386_PG_PS 0x080 >>> #define I386_PG_FRAME_PAE (0x000ffffffffff000ull) >>> #define I386_PG_PS_FRAME_PAE (0x000fffffffe00000ull) >>> -#define I386_PG_FRAME (0xfffff000) >>> -#define I386_PG_PS_FRAME (0xffc00000) >>> +#define I386_PG_FRAME (0xfffff000u) >>> +#define I386_PG_PS_FRAME (0xffc00000u) >>> >>> #ifdef __i386__ >>> _Static_assert(PAGE_SHIFT == I386_PAGE_SHIFT, "PAGE_SHIFT mismatch"); >> >> This passed a universe build on HEAD. If you can test that it fixes the 9.3 -> 11.0 >> bootstrap I will commit it. > > I'll fire up a 9.3 VM and give it a shot. > Thanks :)!! Hmmc no bueno on ref9-amd64. What likely needs to be done is that the directory needs to be built by itself with gcc on i386. Thanks! -NGie cc1: warnings being treated as errors In file included from /scratch/tmp/ngie/svn/lib/libkvm/kvm_i386.c:63: /scratch/tmp/ngie/svn/lib/libkvm/kvm_i386.h:73: warning: comparison between signed and unsigned *** [kvm_i386.So] Error code 1 bmake[5]: stopped in /scratch/tmp/ngie/svn/lib/libkvm 1 error bmake[5]: stopped in /scratch/tmp/ngie/svn/lib/libkvm *** [lib/libkvm__L] Error code 2 bmake[4]: stopped in /scratch/tmp/ngie/svnhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6A4DDA2E-F07D-420A-9D24-C53C2036723C>