Date: Sun, 31 Dec 2000 21:07:46 +0100 From: Jesper Skriver <jesper@skriver.dk> To: Don Lewis <Don.Lewis@tsc.tdk.com> Cc: Kris Kennaway <kris@FreeBSD.ORG>, Poul-Henning Kamp <phk@critter.freebsd.dk>, security-officer@FreeBSD.ORG, cvs-all@FreeBSD.ORG, freebsd-net@FreeBSD.ORG Subject: Re: what to do now ? Was: cvs commit: src/sys/netinet ip_icmp.c tcp_subr.c tcp_var.h Message-ID: <20001231210746.A81834@skriver.dk> In-Reply-To: <20001220155118.N81814@skriver.dk>; from jesper@skriver.dk on Wed, Dec 20, 2000 at 03:51:18PM %2B0100 References: <20001218182600.C1856@skriver.dk> <20001219222730.A29741@skriver.dk> <200012201046.CAA19456@salsa.gv.tsc.tdk.com> <20001220155118.N81814@skriver.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 20, 2000 at 03:51:18PM +0100, Jesper Skriver wrote:
> On Wed, Dec 20, 2000 at 02:46:21AM -0800, Don Lewis wrote:
>
> > } @@ -714,6 +715,15 @@
> > } (lport && inp->inp_lport != lport) ||
> > } (laddr.s_addr && inp->inp_laddr.s_addr != laddr.s_addr) ||
> > } (fport && inp->inp_fport != fport)) {
> > } + inp = inp->inp_list.le_next;
> > } + continue;
> >
> > Wouldn't it be more cleaner (gets rid of the loop) and more efficient (if
> > we're getting blasted with ICMP messages) to use in_pcblookup_hash()?
>
> I didn't change the loop, but I'll have a look at this code, to see if
> we can improve it, but again, to get moving, I'd like to commit this,
> and leave this for a later improvement, ok ?
I've looked at this, and as far as I can see we cannot use
in_pcblookup_hash, as it lookup a single session, and the code can in
other cases act on multiple sessions, path MTU discovery is such a case.
/Jesper
--
Jesper Skriver, jesper(at)skriver(dot)dk - CCIE #5456
Work: Network manager @ AS3292 (Tele Danmark DataNetworks)
Private: Geek @ AS2109 (A much smaller network ;-)
One Unix to rule them all, One Resolver to find them,
One IP to bring them all and in the zone to bind them.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001231210746.A81834>