Date: Sat, 27 Jun 2026 09:04:14 -0400 From: "Siva Mahadevan" <siva@FreeBSD.org> To: =?utf-8?q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> Cc: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 5b8c28adb829 - main - ping/tests: expect bell chars from stderr after initial status Message-ID: <DJJUPSMWKRI2.3M9O02MGH66CV@FreeBSD.org> In-Reply-To: <86bjcwdxet.fsf@ltc.des.dev> References: <6a3f0534.34ab3.7098834f@gitrepo.freebsd.org> <86bjcwdxet.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
On Sat Jun 27, 2026 at 66:00 UTC, Dag-Erling Smørgrav <des@FreeBSD.org> wrote: > Siva Mahadevan <siva@FreeBSD.org> writes: >> commit 5b8c28adb829b50fb8ac065637fa99f717858bab >> Author: Siva Mahadevan <siva@FreeBSD.org> >> AuthorDate: 2026-06-26 12:22:57 +0000 >> Commit: Siva Mahadevan <siva@FreeBSD.org> >> CommitDate: 2026-06-26 22:46:09 +0000 >> >> ping/tests: expect bell chars from stderr after initial status >> >> After 141bb85798 and 8bda488114f3, ping(8) first writes and flushes the >> initial status to stdout, then writes notification bell characters to stderr. >> >> This patch corrects the expected order of the output to stdout and stderr. >> This is a temporary fix; the test should be rewritten to separate the output >> streams and run expectations on each individually. >> >> Reviewed by: des >> MFC after: 3 days >> Sponsored by: The FreeBSD Foundation > > The change is correct, but the commit message is not, and reads like a > chatbot. Please revert and re-commit with a correct human-written log > message. I do not use LLMs or chatbots. I wrote this by hand. If it is incorrect, my apologies, but I'm not sure in which way. I wrote this from what I understood from the comments in the associated reviews[0][1]. Can you suggest a better commit message? And I'm not sure it warrants a revert and re-commit. [0] https://reviews.freebsd.org/D57765 [1] https://ron-dev.freebsd.org/FreeBSD/src/pulls/50home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DJJUPSMWKRI2.3M9O02MGH66CV>