Date: Wed, 11 Mar 2015 09:39:15 +0000 From: "zbb (Zbigniew Bodek)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2018: Introduce Annapurna Labs AHCI support Message-ID: <aadbf5f481b35ed3ad3c3536eee938a4@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org> References: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
zbb added inline comments. INLINE COMMENTS sys/dev/ahci/ahci.c:150-153 **Jakub Palider wrote:** >I have overlooked it in the specs and took the CAP register RW for >granted. You are right, writing to RO registers doesn't sound fine, and >we don't like it either. But we have little choice but to perform the >writes to make it operational. >You say adding it to quirks is not proper place? Where then? sys/dev/ahci/ahci.c:199-201 **Jakub Palider wrote:** >I'd prefer read MAY/SHOULD/MUST but the spec simply says that it is >loaded by the BIOS. However in reality that does not always happen and >higher level stuff suffers from broken implementations. Linux does it >and although it is not our reference it shows a way to just make things >work. Again - is adding platform quirks wrong way? REVISION DETAIL https://reviews.freebsd.org/D2018 To: zbb, mav, imp, smh Cc: freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aadbf5f481b35ed3ad3c3536eee938a4>