Date: Mon, 21 Sep 2009 13:08:08 +0200 From: Thomas Backman <serenity@exscape.org> To: Brooks Davis <brooks@FreeBSD.org> Cc: Bruce Cran <bruce@cran.org.uk>, svn-src-head@FreeBSD.org Subject: Re: svn commit: r195843 - in head: lib/libkvm sys/kern sys/sys Message-ID: <5A148FA5-4B30-46AF-8A65-1B5E18F43C8B@exscape.org> In-Reply-To: <20090908194311.GB32690@lor.one-eyed-alien.net> References: <200907241503.n6OF3ATP013228@svn.freebsd.org> <20090829201228.00005860@unknown> <20090904221432.GC82231@lor.one-eyed-alien.net> <20090906044700.5208ba62@gluon.draftnet> <20090908194311.GB32690@lor.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 8, 2009, at 9:43 PM, Brooks Davis wrote: > On Sun, Sep 06, 2009 at 04:47:00AM +0100, Bruce Cran wrote: >> On Fri, 4 Sep 2009 17:14:32 -0500 >> Brooks Davis <brooks@FreeBSD.org> wrote: >> >>> On Sat, Aug 29, 2009 at 08:12:28PM +0100, Bruce Cran wrote: >>>> On Fri, 24 Jul 2009 15:03:10 +0000 (UTC) >>>> Brooks Davis <brooks@FreeBSD.org> wrote: >>>> >>>>> Author: brooks >>>>> Date: Fri Jul 24 15:03:10 2009 >>>>> New Revision: 195843 >>>>> URL: http://svn.freebsd.org/changeset/base/195843 >>>>> >>>>> Log: >>>>> Revert the changes to struct kinfo_proc in r194498. Instead, >>>>> fill in up to 16 (KI_NGROUPS) values and steal a bit from >>>>> ki_cr_flags (all bits currently unused) to indicate overflow with >>>>> the new flag KI_CRF_GRP_OVERFLOW. >>>>> >>>>> This fixes procstat -s. >>>>> >>>>> Approved by: re (kib) >>>> >>>> Hi Brooks, >>>> >>>> This checkin appears to have broken crash dump support: the bcopy >>>> in >>>> kvm_proc.c crashes when running "ps -ax -M /var/crash/vmcore.x >>>> -N /boot/kernel/kernel", apparently because ucred.cr_groups isn't >>>> valid. Does it need converted using KVM_READ first? >>> >>> Sorry for the delay, I believe you are correct we need to use >>> kvm_read >>> here instead of the bcopy. Do you still have a core handy you can >>> test a patch against? The following should do it. >> >> The patch has fixed the crash, and data is now returned too. > > Thanks for testing! I've committed the patch and will MFC in the next > week or so. MFC coming up? The patch fixes the segfault for me as well, and this should *really* make it into 8.0. Regards, Thomas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5A148FA5-4B30-46AF-8A65-1B5E18F43C8B>