Date: Sat, 27 Jun 2026 15:13:01 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: "Siva Mahadevan" <siva@FreeBSD.org> Cc: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 5b8c28adb829 - main - ping/tests: expect bell chars from stderr after initial status Message-ID: <867bnkdt42.fsf@ltc.des.dev> In-Reply-To: <DJJUPSMWKRI2.3M9O02MGH66CV@FreeBSD.org> (Siva Mahadevan's message of "Sat, 27 Jun 2026 09:04:14 -0400") References: <6a3f0534.34ab3.7098834f@gitrepo.freebsd.org> <86bjcwdxet.fsf@ltc.des.dev> <DJJUPSMWKRI2.3M9O02MGH66CV@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
"Siva Mahadevan" <siva@FreeBSD.org> writes: > If it is incorrect, my apologies, but I'm not sure in which way. I wrote > this from what I understood from the comments in the associated > reviews[0][1]. You ignored this: https://ron-dev.freebsd.org/FreeBSD/src/pulls/50#issuecomment-853 and this: https://reviews.freebsd.org/D57884 and misrepresented the parts you did not ignore. 1) ping was incorrectly mixing buffered and unbuffered I/O on the same descriptor (standard output), which is not permitted by the standard and results in undeterministic output. 2) My first commit to ping had the side effect of changing the ordering of ping's output in the conditions established by the test, causing the test to fail. This is not a bug in my commit, it is a bug in the test, which assumes deterministic output from a non-determinstic program. 4) My second commit changed ping to guarantee determinstic output in all cases. 5) Your commit changed the test to expect the output which ping now deterministically produces. > Can you suggest a better commit message? And I'm not sure it warrants a > revert and re-commit. The current message is pure fiction, reverting and re-committing is the only way to correct the record. DES -- Dag-Erling Smørgrav - des@FreeBSD.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?867bnkdt42.fsf>