Date: Fri, 3 Nov 2017 15:28:25 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325116 - head Message-ID: <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> In-Reply-To: <201710300312.v9U3CcCT021416@repo.freebsd.org> References: <201710300312.v9U3CcCT021416@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pgPP7DPs5xF97Lq8QmsdmDWa12bhLKJJ9 Content-Type: multipart/mixed; boundary="SpU4G7rf55SnwvJPEs3FlO9GkhgR0f2an"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> Subject: Re: svn commit: r325116 - head References: <201710300312.v9U3CcCT021416@repo.freebsd.org> In-Reply-To: <201710300312.v9U3CcCT021416@repo.freebsd.org> --SpU4G7rf55SnwvJPEs3FlO9GkhgR0f2an Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/29/2017 8:12 PM, Warner Losh wrote: > Author: imp > Date: Mon Oct 30 03:12:38 2017 > New Revision: 325116 > URL: https://svnweb.freebsd.org/changeset/base/325116 >=20 > Log: > Return proper status from buildenv. > =20 > make buildenv BUILDENV_SHELL=3D<some command> more useful. Remove '||= > true' from the command line so that errors are properly > returned. There appears to be no reason for it, and it dates back to > the original commit by ru@. > =20 > Sponsored by: Netflix Now simply running 'make buildenv' and 'exit' throws a make error. Perhaps we need a BUILDENV_CMDS that does what you want and we otherwise leave the ${BUILDENV_SHELL} || true handling. >=20 > Modified: > head/Makefile.inc1 >=20 > Modified: head/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Makefile.inc1 Mon Oct 30 03:12:34 2017 (r325115) > +++ head/Makefile.inc1 Mon Oct 30 03:12:38 2017 (r325116) > @@ -991,8 +991,7 @@ buildenv: .PHONY > .if ${BUILDENV_SHELL:M*zsh*} > @echo For ZSH you must run: export CPUTYPE=3D${TARGET_CPUTYPE} > .endif > - @cd ${BUILDENV_DIR} && env ${WMAKEENV} BUILDENV=3D1 ${BUILDENV_SHELL}= \ > - || true > + @cd ${BUILDENV_DIR} && env ${WMAKEENV} BUILDENV=3D1 ${BUILDENV_SHELL}= > =20 > TOOLCHAIN_TGTS=3D ${WMAKE_TGTS:Neverything:Nbuild${libcompat}} > toolchain: ${TOOLCHAIN_TGTS} .PHONY >=20 --=20 Regards, Bryan Drewery --SpU4G7rf55SnwvJPEs3FlO9GkhgR0f2an-- --pgPP7DPs5xF97Lq8QmsdmDWa12bhLKJJ9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/O2KAAoJEDXXcbtuRpfPp44H/0gqCh0jaPTYRDX0b+wLXEWK +Jk3y2GaUIaYGr9TyJPdkzj4aVdIhOet6GCFxPVEuvM/tGUtSz0bFblZ5yZGvEUr rkv+ivTfio/uSIRVgQPDjZ//3wWbY98XzWnVFWfkHccbFpB/+/+LMSpzdWhcyrsF 3mcRlIJsFZT9gd0lcHFiughNin40VmK4/YOnP5jtOsJA42Hm1ILwywPTHbHhrXzW 1UgGAK24U94qvBTSCkgUmOp3Ke2u3FuEnfFQL6xFFOHyIwXddu/BgOgdU7/w/GCd vxjW4+Q13CpLO9VxpNnjOwBfRtIsS4NLgRGb5S2lSG787ARHjhJXTCqD8pXP7KE= =sq8y -----END PGP SIGNATURE----- --pgPP7DPs5xF97Lq8QmsdmDWa12bhLKJJ9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8d9e9f50-035c-403c-3bc5-6788b7a94dea>