Date: Wed, 22 Aug 2001 21:43:34 -0700 From: Julian Elischer <julian@elischer.org> To: Mike Silbersack <silby@silby.com> Cc: Dave Zarzycki <zarzycki@freebsd.org>, freebsd-net@freebsd.org Subject: Re: RFC: SACK/FACK patch port to Current Message-ID: <3B8489F6.2F1EF3A6@elischer.org> References: <Pine.BSF.4.30.0108222028520.14763-100000@niwun.pair.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Silbersack wrote:
>
> On Wed, 22 Aug 2001, Dave Zarzycki wrote:
>
> > Attached and tested.
> >
> > I'd like to merge this in unless anybody objects.
> >
> > davez
> >
> > --
> > Dave Zarzycki
>
> I haven't done any testing of this code, but having SACK support would
> certainly be nice, so I think committing it to -current with the intention
> of a long testing period before mfcing is a good idea.
>
> However, before that is done, I think some changes should be made; all the
> #ifdef SACK and #ifdef FACKs are ugly. They should be taken out, and
> runtime tuneables (defaulting to on) should be added around the pieces of
> code that actually control SACK and FACK initialization at socket setup
> time. This will ensure that it gets wide testing, and at the same time
> will allow people who suspect that it is causing problems to still turn it
> off.
>
> Once those changes are made, it's probably best to have 2-3 other
> committers test and review before committing.
I usually add a new feature with #ifdefs for the first few weeks
and take them out after I'm confident that it's safe..
>
> Mike "Silby" Silbersack
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-net" in the body of the message
--
+------------------------------------+ ______ _ __
| __--_|\ Julian Elischer | \ U \/ / hard at work in
| / \ julian@elischer.org +------>x USA \ a very strange
| ( OZ ) \___ ___ | country !
+- X_.---._/ presently in San Francisco \_/ \\
v
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B8489F6.2F1EF3A6>