Date: Tue, 8 Jul 2014 08:58:45 -0600 From: Warner Losh <imp@bsdimp.com> To: Julian Elischer <julian@freebsd.org> Cc: svn-src-head@freebsd.org, Warner Losh <imp@FreeBSD.org> Subject: Re: svn commit: r268376 - head/bin/rm Message-ID: <37C52A06-1FBA-4750-A6CC-F89B0347BED3@bsdimp.com> In-Reply-To: <53BB9911.60804@freebsd.org> References: <201407072321.s67NLL7p070713@svn.freebsd.org> <53BB9911.60804@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_33D144FF-CB14-4772-B6B1-27DC415B46F5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jul 8, 2014, at 1:09 AM, Julian Elischer <julian@freebsd.org> wrote: > On 7/8/14, 7:21 AM, Warner Losh wrote: >> Author: imp >> Date: Mon Jul 7 23:21:20 2014 >> New Revision: 268376 >> URL: http://svnweb.freebsd.org/changeset/base/268376 >>=20 >> Log: >> rm -rf can fail sometimes with an error from fts_read. Make it = honor >> fflag to ignore fts_read errors, but stop deleting from that = directory >> because no further progress can be made. >> When building a kernel with a high -j value on a high core count >> machine, during the cleanobj phase we can wind up doing multiple rm >> -rf at the same time for modules that have subdirectories. This >> exposed this race (sometimes) as fts_read can return an error if = the >> directory is removed by another rm -rf. Since the intent of the -f >> flag was to ignore errors, even if this was a bug in fts_read, we >> should ignore the error like we've been instructed to do. > One could make an argument that being unable to delete something = because someone else deleted it first is a "non error". > Even without -f rm is supposed to return an error when you try to delete something that = isn=92t there. Do you have a standards quote handy? Warner --Apple-Mail=_33D144FF-CB14-4772-B6B1-27DC415B46F5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTvAclAAoJEGwc0Sh9sBEAaxcP/0aq+6Hq7+88cTprWH4RHfWM dx6jB0DtpA/8lzCNiKCW5UVOegvOtRNHmZlIyng+wo6XTXz4M5ETsAImdcvGcuA9 TnobVBtW0cGSudBdxTw+uPxDyGN3GCSSVxAj9i05914p/1efhWW9Udhzagz69PiI 0qShIUL2vITNzQs9CUbeS4omLFwH5eiOxrPb1swgDefssRxLeaUmvQrQJOTNCs3E y2KXC3+v7Efd8LWEQKVEtj7oTG3IlCOLdOeO3Sq5vy8lIvDIAlZz3b/kr24lJ3KW dWQzG+eI2vTi/CN+Gmyu1Yqj8jAJavGf+IJjMF+gjCXiQbmOkuYWx2wzuuRIXjvp tKEQW2SAOp81J7OjABBSvDr2ZQdFMp+KrXqouCgBZYpQgaP423J/c9NAEvlbLBPU AWsrqOCuwUluaRtm+s5zI4+G1F3auo+UZV+xJw0itnQvkQUG3eHUgxc/j6iXAua8 eLPtPgeaHQxLk7EPO4xIDYU5w76aZ7pyvwT+fss3kJdb69c5mliGoHgL1JBLh0VX k0Fyhk1HVVmbQoPgddHC65jRFRLpvUEg5eSsNe+T5wHnaV7fSQ/y4o0q0lEDljYz qHVYLEUPKYi5E1Mr8FFyL7n6pj46HKzIAMeJRa0s66A131ckgbMv02y43qNWSijp GtfqCu6IFzoYks1aHbiT =utBI -----END PGP SIGNATURE----- --Apple-Mail=_33D144FF-CB14-4772-B6B1-27DC415B46F5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37C52A06-1FBA-4750-A6CC-F89B0347BED3>