Date: Mon, 22 Sep 2025 08:07:08 +0200 From: "Herbert J. Skuhra" <herbert@gojira.at> To: Guido Falsi <madpilot@FreeBSD.org> Cc: Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 31ec8b6407fd - main - sys/netinet6: Implement RFC 7217 Message-ID: <87plbj9g1f.wl-herbert@gojira.at> In-Reply-To: <63c07846-cd1b-4ff2-8c35-c0a6db6954cc@FreeBSD.org> References: <202509201231.58KCVqBC047480@gitrepo.freebsd.org> <874iswhip4.wl-herbert@gojira.at> <bad8cb94-8243-468a-9919-a713a9426eae@FreeBSD.org> <07503de1-785e-4e4d-b4e4-0524aeb064e1@FreeBSD.org> <87jz1sc9fr.wl-herbert@gojira.at> <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org> <aNBKeJwyBFpkt77b@cell.glebi.us> <909b3e33-0639-4abc-915f-073cd0f304da@FreeBSD.org> <aNCDmk7dcv8jE7yi@cell.glebi.us> <63c07846-cd1b-4ff2-8c35-c0a6db6954cc@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Sep 2025 02:26:12 +0200, Guido Falsi wrote: > > On 9/22/25 01:00, Gleb Smirnoff wrote: > > On Sun, Sep 21, 2025 at 09:17:15PM +0200, Guido Falsi wrote: > > G> > Is struct nd_ifinfo something that is used as argument to ioctl(2)? > > G> > If so, then adding counter_u64_t into it is not correct. > > G> > > > G> > I would suggest to not revert the change as a whole, but remove the > > G> > counter only and bring struct nd_ifinfo back to original. The counter > > G> > should probably go into struct in6_ifextra that is pointed by > > G> > if->if_afdata[AF_INET6]. > > G> > > G> Thanks for the feedback and suggestion! > > G> > > G> You are definitely right! I'm in the process to create a review for such a > > G> change shortly, I'll post it as soon as I'm able to have the code tested. > > > > As long as Herbert confirms that the patch fixes the issue for him, please > > consider the change as approved by an src committer and please push it. We > > want to enter the stabweek that starts tomorrow without a ABI breakage. > > > > @Herbert I'm attaching a patch against base sources for you to test. > > It moves the new counter to in6_ifextra structure, removing the ABI > breakage I introduced. Everything should be back to working with this. > > Can you confirm it fixes the issue for you? Thanks a lot, this patch fixes the issue.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?87plbj9g1f.wl-herbert>