Date: Fri, 3 Nov 2017 15:40:57 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325116 - head Message-ID: <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> In-Reply-To: <CANCZdfpXuLkS843%2BjneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2%2BLg@mail.gmail.com> References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <CANCZdfpXuLkS843%2BjneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2%2BLg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8atGHB3OAANrBLIH0Vxcn7POljN0jWmap Content-Type: multipart/mixed; boundary="F0thaUpI3tD43cS3KRQhVjs8FWFsX3N0f"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Warner Losh <imp@bsdimp.com> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2@FreeBSD.org> Subject: Re: svn commit: r325116 - head References: <201710300312.v9U3CcCT021416@repo.freebsd.org> <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> <CANCZdfpXuLkS843+jneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2+Lg@mail.gmail.com> In-Reply-To: <CANCZdfpXuLkS843+jneBzCYCsM5ZvV_Tm=zxzt73-wiD3C2+Lg@mail.gmail.com> --F0thaUpI3tD43cS3KRQhVjs8FWFsX3N0f Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/3/2017 3:32 PM, Warner Losh wrote: >=20 >=20 > On Fri, Nov 3, 2017 at 4:28 PM, Bryan Drewery <bdrewery@freebsd.org > <mailto:bdrewery@freebsd.org>> wrote: >=20 > On 10/29/2017 8:12 PM, Warner Losh wrote: > > Author: imp > > Date: Mon Oct 30 03:12:38 2017 > > New Revision: 325116 > > URL: https://svnweb.freebsd.org/changeset/base/325116 > <https://svnweb.freebsd.org/changeset/base/325116>; > > > > Log: > >=C2=A0 =C2=A0Return proper status from buildenv. > > > >=C2=A0 =C2=A0make buildenv BUILDENV_SHELL=3D<some command> more us= eful. Remove '|| > >=C2=A0 =C2=A0true' from the command line so that errors are proper= ly > >=C2=A0 =C2=A0returned. There appears to be no reason for it, and i= t dates back to > >=C2=A0 =C2=A0the original commit by ru@. > > > >=C2=A0 =C2=A0Sponsored by: Netflix >=20 > Now simply running 'make buildenv' and 'exit' throws a make error. >=20 > Perhaps we need a BUILDENV_CMDS that does what you want and we othe= rwise > leave the ${BUILDENV_SHELL} || true handling. >=20 >=20 > Are you sure? >=20 > 4:29pm zooty:[242]> make buildenv > Entering world for amd64:amd64 > $ exit > 4:29pm zooty:[243]> >=20 > Perhaps you can give me an example that causes that? This was the very > first thing I checked before committing the fix... >=20 Only happens with zsh. > [root@c1100-1][pts/8][zsh/2][Fri 11/03/2017 15:40:10 PDT][0?2&] (git-sv= n)-[master]- > ~/git/freebsd # BUILDENV_SHELL=3Dcsh make buildenv > Entering world for amd64:amd64 > root@c1100-1:~/git/freebsd # exit > exit > ~/git/freebsd # BUILDENV_SHELL=3D/usr/local/bin/zsh make buildenv > Entering world for amd64:amd64 > For ZSH you must run: export CPUTYPE=3D > (buildenv) [root@c1100-1][pts/8][zsh/3][Fri 11/03/2017 15:40:23 PDT][1?= 0&] (git-svn)-[master]- > ~/git/freebsd # exit > *** Error code 1 >=20 > Stop. > make[1]: stopped in /root/git/freebsd > *** Error code 1 >=20 > Stop. > make: stopped in /root/git/freebsd --=20 Regards, Bryan Drewery --F0thaUpI3tD43cS3KRQhVjs8FWFsX3N0f-- --8atGHB3OAANrBLIH0Vxcn7POljN0jWmap Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/PB5AAoJEDXXcbtuRpfPpMcH/j6gmqnAORotHtqWXIRQfyjL 2gPfNg0EO+IQ7Z9chohZUfwMDaHGwzMhVi/sXJD1Voq3gtnftDSL8unxDd7Y7tRf vV/H57lSZnfnRvZfL1YnE30N2Sc4ZGnqQcAiDEFdpkTxuC2ZbC4uMwJkW9AWpLiD DGLFg1om4gyJblu8VZz0tI10Am7Jc+y4N0XB3SfkTRdD+wscPJpTBC0hbf1La5mZ dKEYpjIGnRU3WITXFRsr0+If9S4ifdaqIXI5P+dI5if6xiSLw8Fk9Ab99iIRALty CU9ztvauyawBUDS+T+l8DfU+mimnZ+5xa/G4uqaaf3HoZAys44DhjHxlZxnLPm0= =B5Ua -----END PGP SIGNATURE----- --8atGHB3OAANrBLIH0Vxcn7POljN0jWmap--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?72ee6c6d-0d9a-ebe9-8e15-c278fc91ded2>