Date: Thu, 23 Feb 2017 11:13:14 -0600 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: "Pedro F. Giffuni" <pfg@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r314142 - head/sys/dev/ce Message-ID: <CAJ5_RoCw8JEzWybqpsvBm%2BvRUqkVK76zcnvS9omdo79j7QaqTg@mail.gmail.com> In-Reply-To: <201702231530.v1NFULwx024028@repo.freebsd.org> References: <201702231530.v1NFULwx024028@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <pfg@freebsd.org> wrote: > Author: pfg > Date: Thu Feb 23 15:30:21 2017 > New Revision: 314142 > URL: https://svnweb.freebsd.org/changeset/base/314142 > > Log: > dev/ce: double assignment. > > The code is not operational right now so just comment away an obviously > useless assignment. Fix some typos while here. > > Found with: coccinelle (da.cocci) > > Modified: > head/sys/dev/ce/ceddk.c > > Modified: head/sys/dev/ce/ceddk.c > ============================================================ > ================== > --- head/sys/dev/ce/ceddk.c Thu Feb 23 15:10:46 2017 (r314141) > +++ head/sys/dev/ce/ceddk.c Thu Feb 23 15:30:21 2017 (r314142) > @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c) > "UserRequest (%s:%d)\n", __FUNCTION__, > __LINE__)); > return; > } > - req->Command = TAU32_Configure_Commit | > - TAU32_Tx_Stop | TAU32_Rx_Stop; > +// req->Command = TAU32_Configure_Commit | > +// TAU32_Tx_Stop | TAU32_Rx_Stop; > Should probably stick to C-style comments, though. -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoCw8JEzWybqpsvBm%2BvRUqkVK76zcnvS9omdo79j7QaqTg>