Date: Wed, 30 Jan 2002 16:06:17 -0500 From: Garance A Drosihn <drosih@rpi.edu> To: Alfred Perlstein <bright@mu.org>, Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Terry Lambert <tlambert2@mindspring.com>, Jordan Hubbard <jkh@winston.freebsd.org>, Dallas De Atley <deatley@apple.com>, arch@FreeBSD.ORG Subject: Re: __P macro question Message-ID: <p0510121ab87e0a53ed73@[128.113.24.47]> In-Reply-To: <20020130112600.I13686@elvis.mu.org> References: <3C57C858.5FCC9453@mindspring.com> <21755.1012385956@critter.freebsd.dk> <20020130112600.I13686@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 11:26 AM -0800 1/30/02, Alfred Perlstein wrote:
>Removing the __P causes these specific problems:
>
>1) repo bloat.
In the past, we have generated "repo-bloat" just to remove unneeded
blanks at the end of lines. If we survived it for that, we can
survive it for removing __P()'s. We're constantly doing style fixes
which "bloat" the repo.
>2) incompatible deltas with other BSDs and older versions of BSD.
Note that this is less true than it used to be. For instance, a recent
contribution sent to freebsd-standards said:
This patch adds the -b and -s options to 'fold'. It's mostly
taken from NetBSD but I've hopefully kept it compile-able by
K&R compilers.
In other words, here's someone who is taking code *from* NetBSD,
and *adding* __P()'s to it. Why does he have to add them? Because
more than 16 months ago, NetBSD applied an update to 'fold' where
the commit message was:
(and I quote)
Un-__P and ANSIfy.
So, while it used to be that there was an advantage in keeping __P()'s
so we would remain the same as some other BSD, we now have some new
developers who think they should *add* __P()'s to become *incompatible*
with another BSD. Clearly we're sending the wrong signal to people who
are trying to contribute to FreeBSD. Time has moved on.
--
Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0510121ab87e0a53ed73>