Date: Sun, 24 Nov 2002 23:15:57 +0200 From: Giorgos Keramidas <keramida@freebsd.org> To: Brad Knowles <brad.knowles@skynet.be> Cc: Cliff Sarginson <cls@raggedclown.net>, freebsd-chat@freebsd.org Subject: Re: Style(9) question Message-ID: <20021124211557.GB1145@gothmog.gr>
next in thread | raw e-mail | index | archive | help
In-Reply-To: <a05200f00ba06e3101ce9@[10.0.1.2]> On 2002-11-24 21:12, Brad Knowles <brad.knowles@skynet.be> wrote: > At 6:27 PM +0200 2002/11/24, Giorgos Keramidas wrote: > > Not really "rejected", but if you troll the PR database for a while, > > you will notice followups to the spirit of ``This looks fine, but it > > doesn't fit the style of the affected sources. Can you please fix > > this, and post the new patch in a followup?'' > > And how many times has a modified patch been submitted as a > follow-up, versus how many times people didn't bother to ever again > file a PR? I haven't really looked, but if one were to do a ``human resources'' type of research, you'd also have to include cases where a committer makes changes to the submitted patches (and separate these in two cases too, depending on whether the original submitter was annoyed or not). That's a bit difficult to do though, since a lot of the people who are annoyed by such changes probably don't bother mailingn gnats about it... I always try to be as gentle as I can, when I need to make changes to submitted patches, and I can only hope that it doesn't make anyone too upset, leading them to stop working with FreeBSD. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021124211557.GB1145>