Date: Fri, 15 Jun 2007 21:03:18 +0400 From: "Andrew Pantyukhin" <infofarmer@FreeBSD.org> To: "Li-Wen Hsu" <lwhsu@freebsd.org> Cc: cvs-ports@freebsd.org, YUAN Jue <yuanjue@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/devel/kdesvn Makefile distinfo pkg-plist Message-ID: <cb5206420706151003ha34175ep52551e538e2e7f8d@mail.gmail.com> In-Reply-To: <20070615164901.GA86604@FreeBSD.csie.nctu.edu.tw> References: <200706151428.l5FESrEq080128@repoman.freebsd.org> <20070615142857.64CA516A498@hub.freebsd.org> <cb5206420706150837k7cf47262q3beb677705a49f9f@mail.gmail.com> <20070615164901.GA86604@FreeBSD.csie.nctu.edu.tw>
index | next in thread | previous in thread | raw e-mail
On 6/15/07, Li-Wen Hsu <lwhsu@freebsd.org> wrote:
> On Fri, Jun 15, 2007 at 19:37:15 +0400, Andrew Pantyukhin wrote:
> > > +.if !defined(NOPORTDOCS)
> > > +DOCSDIR= ${PREFIX}/share/doc/HTML/en/kdesvn
> > > .endif
> >
> > Is there any merit to this DOCSDIR definition being
> > conditional?
>
> Seems no. Sometimes I put this in the Makefile:
>
> .if !defined(NOPORTDOCS)
> DOCSDIR= /some/other/place
> PORTDOCS= *
> .endif
In spite of what bsd.port.mk says, PORTDOCS can be safely
defined even if NOPORTDOCS is defined. Acting on PORTDOCS
is conditionalized by this line:
.if defined(PORTDOCS) && !defined(NOPORTDOCS)
> Besides, though I don't really care where the review goes. (I am very happy
> with this) But since some people don't like this. How about replying the
> commit in private, and maintaining a "Common Mistakes when Porting" list,
> after a number of items collected? Posting it to ports@ list and put into
> the porter's handbook might be a good idea. This can get more porters'
> attention, and easier to find. Sometimes, looking for something in the
> high-traffic mailing list is quite hard. After all, not everyone read
> every commit message and its reply, but every should read the handbook
> (and read again when it is updated), right?
The thing I hope for is that the guys that are so kindly
watching me right now will later help us do the very thing
you describe - figuring out the most common mistakes and
documenting some best practices to avoid them. I'm afraid
I won't be able to do it all alone.
Moreover, as we've already seen, the pleasant part of the
public resonance contributes invaluable opinions to many
issues.
Thanks!
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb5206420706151003ha34175ep52551e538e2e7f8d>