Date: Tue, 16 Oct 2012 11:21:18 +0200 From: Fabien Thomas <fabien.thomas@netasq.com> To: hiren panchasara <hiren.panchasara@gmail.com> Cc: freebsd-current <freebsd-current@freebsd.org>, Davide Italiano <davide.italiano@gmail.com> Subject: Re: [CFT]hwpmc update for sandybridge-e Message-ID: <15825760-628D-4073-813A-DD2449BDC6FB@netasq.com> In-Reply-To: <CALCpEUGdQ3ex_zopmBY_Xmf1dsB_2crZXUhnuCmYpNVTmpHF_Q@mail.gmail.com> References: <1349390777.5234.9.camel@powernoodle.corp.yahoo.com> <E62FEDB0-2DB8-408F-8D2B-3A40526035AB@netasq.com> <D67C86BC-B139-4472-9FE0-E09725D1CB55@netasq.com> <CALCpEUGNRzWgmaj2KDj8VkHMjw_6uGvcjSiWT-t%2B63iUUsh64g@mail.gmail.com> <D0A99DA2-8348-441F-ACD1-BAF79AC89D14@netasq.com> <CALCpEUGdQ3ex_zopmBY_Xmf1dsB_2crZXUhnuCmYpNVTmpHF_Q@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
Le 16 oct. 2012 à 02:49, hiren panchasara a écrit : > > > On Mon, Oct 15, 2012 at 1:12 AM, Fabien Thomas <fabien.thomas@netasq.com> wrote: > > Le 13 oct. 2012 à 00:54, hiren panchasara a écrit : > > > > > > > On Fri, Oct 5, 2012 at 1:05 AM, Fabien Thomas <fabien.thomas@netasq.com> wrote: > > > > Le 5 oct. 2012 à 10:00, Fabien Thomas a écrit : > > > > > > > > Le 5 oct. 2012 à 00:46, Sean Bruno a écrit : > > > > > >> So, I did the bear minimum and kind of hacked things together without > > >> understanding precisely what I was doing, and I was able to massage the > > >> sandybridge-e CPUs into giving me some basic functions. > > >> > > >> Comments or concerns before I commit this? > > >> > > >> http://people.freebsd.org/~sbruno/pmc_sandybridge.txt > > > > > > Hi Sean, > > > > > > The only modification required is this one > > > http://svnweb.freebsd.org/base?view=revision&revision=237196 > > > > > > but davide@ removed it for a problem that need to be looked at. > > > > Looking at the doc this CPU require a full set of PMC as the list of event are different. > > So this mean full manpage, full event list, … > > > > Doc: > > " > > The events in Table 19-3 apply to > > processors with CPUID signature of DisplayFamily_DisplayModel encoding with the > > following values: 06_2AH and 06_2DH. The events in Table 19-4 apply to processors > > with CPUID signature 06_2AH. The events in Table 19-5 apply to processors with > > CPUID signature 06_2DH. > > " > > > > Required change will be the same as this commit if you want to look at it: > > http://svnweb.freebsd.org/base?view=revision&revision=240164 > > > > Hi All, > > > > With help of Sean, I've prepared another semi-working patch: > > http://www.strugglingcoder.info/patches/hwpmc_sbx_1.txt > > Great, i've quickly looked at the patch: > > I'm not sure to understand why you have removed code in your case for uncore. > If you dont want to support remove it like for ivy bridge. > > Thanks Fabien for getting back quickly. As I am not clear about uncore support, I've removed it entirely as you suggested. I've tried to incorporate other comments too. > > New set of diffs, pmccontrol and pmctest.py results are here: > > http://www.strugglingcoder.info/patches/hwpmc_sbx_2.txt > http://www.strugglingcoder.info/patches/pmccontrol_2.txt > http://www.strugglingcoder.info/patches/pmctestpy_2.txt > > I now have following event counters failing from pmctest.py script: > CYCLE_ACTIVITY.CYCLES_L2_PENDING > I think you missed IAP_F_FM. I will look at the new diff later. > BACLEARS.ANY > L2_TRANS.DEMAND_DATA_RD > L2_TRANS.RF0 > SQ_MISC.SPLIT_LOCK > I am not quite sure why these are failing. Will continue looking into it. > > Appreciate your help, > Hirenhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15825760-628D-4073-813A-DD2449BDC6FB>