Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Aug 2005 12:56:44 -0700 (PDT)
From:      Don Lewis <truckman@FreeBSD.org>
To:        csjp@FreeBSD.org
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern kern_sysctl.c
Message-ID:  <200508081956.j78Jui1l095716@gw.catspoiler.org>
In-Reply-To: <200508081854.j78IsaOp043271@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On  8 Aug, Christian S.J. Peron wrote:
> csjp        2005-08-08 18:54:35 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_sysctl.c 
>   Log:
>   Check to see if we wired the user-supplied buffers in SYSCTL_OUT, if
>   the buffer has not been wired and we are holding any non-sleep-able locks,
>   drop a witness warning. If the buffer has not been wired, it is possible
>   that the writing of the data can sleep, especially if the page is not in
>   memory. This can result in a number of different locking issues, including
>   dead locks.

Thanks.

I think SYSCTL_IN() should also check for locks.  We don't have a
function to wire the buffer in this direction.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508081956.j78Jui1l095716>