Date: Tue, 12 Sep 2006 10:20:34 -0400 From: John Baldwin <jhb@freebsd.org> To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/smbus smbus.c src/sys/kern bus_if.m Message-ID: <200609121020.34783.jhb@freebsd.org> In-Reply-To: <20060912140105.22e7c9e3@it.buh.tecnik93.com> References: <200609112220.k8BMKbfG009489@repoman.freebsd.org> <20060912140105.22e7c9e3@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 12 September 2006 07:01, Ion-Mihai Tetcu wrote: > On Mon, 11 Sep 2006 22:20:37 +0000 (UTC) > John Baldwin <jhb@FreeBSD.org> wrote: > > > jhb 2006-09-11 22:20:37 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/smbus smbus.c > > sys/kern bus_if.m > > Log: > > - Revert making bus_generic_add_child() the default for > > BUS_ADD_CHILD(). Instead, we want busses to explicitly specify an > > add_child routine if they want to support identify routines, but by > > default disallow having outside drivers add devices. > > - Give smbus(4) an explicit bus_add_child() method. > > Might it have anything with this ? > > ===> i2c/controllers/viapm (all) > cc -O2 -pipe -DVIAPM_BASE_ADDR=0x6000 -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I- -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/ORION_U_P_O/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -I/usr/obj/usr/src/sys/ORION_U_P_O -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -c /usr/src/sys/modules/i2c/controllers/viapm/../../../../pci/viapm.c > In file included from /usr/src/sys/modules/i2c/controllers/viapm/../../../../pci/viapm.c:54: > @/dev/smbus/smbus.h:34: error: field `lock' has incomplete type > *** Error code 1 No, it would be the earlier commit. It compiled locally. I'll fix. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200609121020.34783.jhb>