Date: Tue, 28 Jul 2015 09:05:57 +0200 From: Ed Schouten <ed@nuxi.nl> To: Marcelo Araujo <araujo@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush usr.sbin/ypserv Message-ID: <CABh_MKmssa3h8MKJawKj_thECxGwCa9cLd5fcwL035_5GHtomw@mail.gmail.com> In-Reply-To: <201507280232.t6S2WfSq043383@repo.freebsd.org> References: <201507280232.t6S2WfSq043383@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Marcelo,
Thanks for working on this!
2015-07-28 4:32 GMT+02:00 Marcelo Araujo <araujo@freebsd.org>:
> -struct ypalias {
> +const struct ypalias {
> char *alias, *name;
> -} ypaliases[] = {
> +} static ypaliases[] = {
> { "passwd", "passwd.byname" },
> { "master.passwd", "master.passwd.byname" },
> { "shadow", "shadow.byname" },
I seem to remember that certain compilers (Intel?) are pretty picky
about the ordering of 'static' and 'const'.
const static int i; // Compiler error.
It's also inconsistent with the rest of our codebase, where we
typically put 'static' in front of the type. Could you please change
this to the following?
static const struct ypalias {
...
} ypaliases[] = {
...
};
Thanks!
--
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK/VAT number: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKmssa3h8MKJawKj_thECxGwCa9cLd5fcwL035_5GHtomw>