Date: Thu, 26 Feb 2004 19:13:13 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Peter Schultz <pmes@bis.midco.net> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/graphics/xaos Makefile Message-ID: <20040227031312.GA11697@xor.obsecurity.org> In-Reply-To: <403EAF98.7080009@bis.midco.net> References: <200402251000.i1PA0nGn056196@repoman.freebsd.org> <403E0B90.9040106@bis.midco.net> <20040226203351.GB5915@xor.obsecurity.org> <403EA170.9080100@bis.midco.net> <20040227015101.GA10403@xor.obsecurity.org> <403EAF98.7080009@bis.midco.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Feb 26, 2004 at 08:46:48PM -0600, Peter Schultz wrote:
> >Set PTHREAD_LIBS='-DNOP -lpthread' PTHREAD_CFLAGS='-DNOP2' or similar
> >and verify that they're showing up correctly in the build log.
> >
>
> I'm not getting the point of this. If I `make -DWITH_THREADS' after
> this patch, xaos is built and linked properly:
>
> cc -DHAVE_SYS_PARAM_H -I/usr/local/include -pipe -O6 -fstrength-reduce
> -ffast-math -fomit-frame-pointer -fforce-mem -fforce-addr -funroll-loops
> -D_REENTRANT -I/usr/include/ncurses -I/usr/X11R6/include
> -I/usr/local/include -I/usr/X11R6/include
> -I/usr/ports/graphics/xaos/work/XaoS-3.0/src/include -L/usr/local/lib -o
> /usr/ports/graphics/xaos/work/XaoS-3.0/bin/xaos lib/libui.a
> lib/libengine.a lib/libutil.a lib/libfilter.a lib/libuiaa.a
> lib/libuix11.a -lpng -lz -lm -laa -lncurses -lpthread
> -L/usr/X11R6/lib -L/usr/X11R6/lib -lX11 -L/usr/X11R6/lib -lX11
> -L/usr/local/lib -L/usr/local/lib -lXext -L/usr/X11R6/lib -lX11
>
> What is -DNOP? Why doesn't textproc/libxml2 require this?
I mentioned -DNOP because it's a null operation that will have no
effect on the build, so you can easily verify from the build output
whether the port is using PTHREAD_CFLAGS and PTHREAD_LIBS for threaded
compilation and linking, or if it is hard-coding its own settings that
it thinks are correct for FreeBSD. It might happen to be choosing
values that correspond to the current default settings in FreeBSD, but
if a user wants to override those defaults, or if FreeBSD changes the
defaults again, then it will be wrong.
Many ports do not correctly use PTHREAD_{CFLAGS,LIBS}, but that's no
reason to add another incorrect one.
Kris
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAPrXIWry0BWjoQKURApKYAJ90vER5TfYUmONAB4m4LY+UBpqq/wCfdoX5
ull/YomwJG9d6sYgZBQVuv4=
=lKUc
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040227031312.GA11697>