Date: Tue, 27 Jan 1998 18:56:25 -0800 (PST) From: Alex <garbanzo@hooked.net> To: Julian Elischer <julian@whistle.com> Cc: current <current@FreeBSD.ORG> Subject: Re: PATCH: if_de.c #ifdef based version encoding Message-ID: <Pine.BSF.3.96.980127185530.228Q-100000@zippy.dyn.ml.org> In-Reply-To: <34CE4438.15FB7483@whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Jan 1998, Julian Elischer wrote: > David Greenman wrote: > > > > >The value of the manifest constant __FreeBSD__ is derived from the > > >compiler tools and not from the kernel being built. > > > > > >In other words, the value of __FreeBSD__ comes from the version of the > > >OS the tools were built on, not from the OS that's running or the one > > >that is being targeted. > > > > > >This means that if I build a v3 kernel using a v2 system's tools, the > > >"#if __FreeBSD__ >= 3" and "#if defined(__FreeBSD__) && __FreeBSD__ >= 3" > > >will not test true, even though that is, in fact, what I am building. > > > > > > > > >Version information should not be encoded in #ifdef's; that is what > > >branch tags are for. If I can check this code out, implicitly, I am > > >building a 3+ system. The "#if" tests are bogus. > > > > > >This patch allows people to compile v3 kernels containing if_de.c on v2 > > >systems. What about osreldate.h?? Doesn't that include a versionish number of sorts for the kernel/tools being built? Linux: The Microsoft Windows(tm) of the Unix(tm) world. - alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.980127185530.228Q-100000>